Pushes all solution files into temp when created #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In temp mapper moves files of solution so we can no longer check against file paths expected as they're always random in temp. Instead we now compare contents to ensure it's as we expect.
This ensures we can keep state allowing invoking the same solution multiple times and not doing FS operations everytime. Side benefit is solutions will not require caching
|
Updated with hopefully passing tests. I refactored some of the tests to hopefully make it more robust and separate the concerns away from knowing the expected path values. @AydinHassan I also put some comments into each commit if you wanted to review the changes of each with a little more context 😄 Let me know what you think about this approach |
Mainly around file paths not being what was expected I chose to compare contents rather than paths as it felt more robust, hower the temp paths are deterministic I just didn't want to crossover logic / concerns of this into these
mikeymike
force-pushed
the
feature/in-temp-solution-mapping
branch
from
1eb405d to
08af37a
Compare
AydinHassan
approved these changes
May 18, 2021
|
@mikeymike nice work, LGTM. I also appreciate the commit comments 👌 |
AydinHassan
reviewed
May 18, 2021
| public function tearDown(): void | ||
| { | ||
| $fileSystem = new Filesystem(); | ||
| $fileSystem->remove(Path::join(realpath(sys_get_temp_dir()), 'php-school')); |
There was a problem hiding this comment.
Probably could have used \PhpSchool\PhpWorkshop\Utils\System::tempDir('php-school') and in a few other places not that it really matters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of ? that replaces #201 with a more sane implementation in smaller more digestible chunks 😄
This will ensure that our internal solutions are moved into temp before running which in turn allows us to patch the files without any impact to our actual solutions. The risk of breaking these solutions from a users code is high as it essentially breaks the whole workshop