Skip to content

Add code exists check #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2021
Merged

Add code exists check #197

merged 3 commits into from
Jan 4, 2021

Conversation

mikeymike
Copy link
Member

Adds a new check to see if the solution has any actual statements.

@mikeymike mikeymike requested a review from AydinHassan January 3, 2021 14:39
@codecov-io
Copy link

codecov-io commented Jan 3, 2021

Codecov Report

Merging #197 (c37f8a6) into master (dc62895) will increase coverage by 0.01%.
The diff coverage is 95.23%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
+ Coverage     91.75%   91.77%   +0.01%     
- Complexity      677      692      +15     
============================================
  Files           100      101       +1     
  Lines          2087     2116      +29     
============================================
+ Hits           1915     1942      +27     
- Misses          172      174       +2     
Impacted Files Coverage Δ Complexity Δ
src/ExerciseRunner/CgiRunner.php 90.74% <ø> (ø) 25.00 <0.00> (ø)
src/ExerciseRunner/CliRunner.php 100.00% <ø> (ø) 20.00 <0.00> (ø)
src/Check/CodeExistsCheck.php 95.23% <95.23%> (ø) 13.00 <13.00> (?)
src/functions.php 57.14% <0.00%> (-9.53%) 0.00% <0.00%> (ø%)
src/Utils/StringUtils.php 100.00% <0.00%> (ø) 9.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc62895...c37f8a6. Read the comment docs.

@AydinHassan AydinHassan merged commit e0fa255 into master Jan 4, 2021
@AydinHassan AydinHassan deleted the code-exists-check branch January 4, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants