Skip to content

Use array_values to fix indexes #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2020
Merged

Use array_values to fix indexes #192

merged 1 commit into from
Dec 12, 2020

Conversation

AydinHassan
Copy link
Member

Found this when writing a test for an exercise which required multiple function usages but only one was used.

@codecov-io
Copy link

Codecov Report

Merging #192 (bfe027d) into master (ddbfdb6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #192   +/-   ##
=========================================
  Coverage     92.36%   92.36%           
  Complexity      672      672           
=========================================
  Files           100      100           
  Lines          2070     2070           
=========================================
  Hits           1912     1912           
  Misses          158      158           
Impacted Files Coverage Δ Complexity Δ
src/NodeVisitor/FunctionVisitor.php 94.11% <100.00%> (ø) 17.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddbfdb6...bfe027d. Read the comment docs.

@AydinHassan AydinHassan merged commit 0ebae36 into master Dec 12, 2020
@AydinHassan AydinHassan deleted the fix-array-indexing branch December 12, 2020 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants