Skip to content

Missing problem file #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 8, 2020
Merged

Missing problem file #190

merged 6 commits into from
Dec 8, 2020

Conversation

AydinHassan
Copy link
Member

Throw an exception when a problem file doesn't exist for better DX

  • Also add better error reporting, we were not catching many exceptions in the Application class before. Now we catch all of them.
  • Also add a canonicalise_path function to resolve ../../ in paths
  • Strip workshop base_path off file path in exception to make exception printing prettier.

@AydinHassan AydinHassan merged commit ddbfdb6 into master Dec 8, 2020
@AydinHassan AydinHassan deleted the missing-problem-file branch December 8, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants