Make sure to pass arguments added by events to the results #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeymike
approved these changes
Feb 28, 2018
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage 95.52% 95.52%
Complexity 648 648
=========================================
Files 94 94
Lines 1987 1987
=========================================
Hits 1898 1898
Misses 89 89
Continue to review full report at Codecov.
|
AydinHassan
force-pushed
the
pass-dynamicall-added-args-to-results
branch
from
fb0a106 to
226ab36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we add arguments via events - they previously did not get passed to the results and therefore would not be printed when verify files or when running via
run.