Skip to content

Php parser 3 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2017
Merged

Php parser 3 #154

merged 4 commits into from
Mar 5, 2017

Conversation

AydinHassan
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 4, 2017

Codecov Report

Merging #154 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #154      +/-   ##
============================================
+ Coverage     95.46%   95.47%   +<.01%     
- Complexity        0      621     +621     
============================================
  Files            94       94              
  Lines          1962     1965       +3     
============================================
+ Hits           1873     1876       +3     
  Misses           89       89
Impacted Files Coverage Δ Complexity Δ
src/Factory/MarkdownCliRendererFactory.php 100% <100%> (ø) 1 <0> (+1)
src/ResultRenderer/ResultsRenderer.php 100% <100%> (ø) 21 <0> (+21)
src/Solution/SolutionFile.php 100% <100%> (ø) 9 <1> (+9)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11c72ff...1770ec4. Read the comment docs.

@AydinHassan AydinHassan requested a review from mikeymike March 5, 2017 09:02
@AydinHassan
Copy link
Member Author

@mikeymike swapped out our psx library for kadet/keylighter as there was a lot of changes in psx due to the upgrade of php-parser. It really wasn't worth fixing and kadet/keylighter seems to be better as well. When code is highlighted it doesn't get modified anymore (white space, formatting, etc).

Swapping out also allows us to easily update to php-parser 3.

Copy link
Member

@mikeymike mikeymike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks spot on ⚡️ 💯 🥇

@mikeymike
Copy link
Member

I guess this also superseeds #152 ?

@mikeymike mikeymike merged commit e0473af into master Mar 5, 2017
@mikeymike
Copy link
Member

I'll leave you to release when your free 👍 (no rush)

@mikeymike mikeymike deleted the php-parser-3 branch March 5, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants