Add tests for ResultRendererFactory class

[TheoKouzelis]

No description provided.

[codecov-io]

Current coverage is 88.80% (diff: 100%)

Merging #126 into master will increase coverage by 0.72%

@@             master       #126   diff @@
==========================================
  Files            69         69          
  Lines          1594       1546    -48   
  Methods         281        282     +1   
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1404       1373    -31   
+ Misses          190        173    -17   
  Partials          0          0          

Powered by Codecov. Last update 6fa4db4...bc185c3

[AydinHassan]

hey @TheoKouzelis what is the advantage of is_subclass_of instead of class_implements ?

[TheoKouzelis]

I think class_implements returns an array of interfaces that the given class implements. http://php.net/manual/en/function.class-implements.php

So I think the previous code started to fail because the following statement would be true if the class implemented any interface and not specifically ResultInterface::class

!class_implements($resultClass, ResultInterface::class)

I think the code could have also been refactored to the following but I thought is_subclass_ofseemed more direct

!in_array(ResultInterface::class, class_implements($resultClass))

[AydinHassan]

oh wow - so it never worked 😂 - nice find!

[AydinHassan]

Thanks @TheoKouzelis !

[TheoKouzelis]

Thanks