Merge pull request #215 from php-school/fix-fs-stuff

Only delete or create stuff if exists or doesn't exist already

Author: AydinHassan

src/Check/DatabaseCheck.php

@@ -138,10 +138,17 @@ function (CliExecuteEvent $e) {
             ],
             function () use ($db) {
                 unset($db);
-                @unlink($this->userDatabasePath);
-                @unlink($this->solutionDatabasePath);
+                $this->unlink($this->userDatabasePath);
+                $this->unlink($this->solutionDatabasePath);
                 rmdir($this->databaseDirectory);
             }
         );
     }
+
+    private function unlink(string $file): void
+    {
+        if (file_exists($file)) {
+            unlink($file);
+        }
+    }
 }

test/BaseTest.php

@@ -31,7 +31,9 @@ public function getTemporaryFile(string $filename, string $content = null): stri
             return $file;
         }
 
-        @mkdir(dirname($file), 0777, true);
+        if (!file_exists(dirname($file))) {
+            mkdir(dirname($file), 0777, true);
+        }
 
         $content !== null
             ? file_put_contents($file, $content)

test/Check/DatabaseCheckTest.php

@@ -89,7 +89,7 @@ private function getRunnerManager(ExerciseInterface $exercise, EventDispatcher $
     public function testIfDatabaseFolderExistsExceptionIsThrown(): void
     {
         $eventDispatcher = new EventDispatcher(new ResultAggregator());
-        @mkdir($this->dbDir);
+        mkdir($this->dbDir, 0777, true);
         try {
             $this->check->attach($eventDispatcher);
             $this->fail('Exception was not thrown');