Skip to content

Re-generated .h files after stubs were modified #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2020
Merged

Re-generated .h files after stubs were modified #469

merged 1 commit into from
Dec 18, 2020

Conversation

GrahamCampbell
Copy link
Contributor

Follow-up to #468.

sodabrew
sodabrew reviewed Dec 18, 2020
View reviewed changes
php_memcached_arginfo.h

ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Memcached___construct, 0, 0, 0)
ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, persistent_id, IS_STRING, 1, "NULL")
Copy link
Collaborator

@sodabrew sodabrew Dec 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a definition for this macro to understand why this fourth argument is changing from 1 to 0.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it was incorrectly changed to 1 in 8f3c5dc#diff-25c321c509d1a97040fdc193f475a75a14a42492da840d7470bd609fbbe915ed. Probably they ran make using an old version of PHP 8.0. I generated this with 8.0.0.

@sodabrew sodabrew merged commit bfb0a66 into php-memcached-dev:master Dec 18, 2020
@GrahamCampbell GrahamCampbell deleted the stubs branch December 19, 2020 01:14
sultan9900
sultan9900 reviewed Dec 31, 2020
View reviewed changes
Copy link

@sultan9900 sultan9900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e('cache', function ($table) {
$table->string('key')->unique();
$table->text('value');
$table->integer('expiration');
});

@driesvints
Copy link

@sodabrew can we get a new tag for this? It's been a while now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodabrew sodabrew sodabrew left review comments

+1 more reviewer

@sultan9900 sultan9900 sultan9900 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GrahamCampbell @driesvints @sodabrew @sultan9900