Sleep more #30
Merged
Sleep more #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
reviewed
Jul 7, 2017
tests/BaseTestCase.php
Outdated
| @@ -13,7 +13,7 @@ public function startServer($name) | |||
| $filename = __DIR__ . '/server/' . $name . '.php'; | |||
| $pipes = []; | |||
| $this->servers[$name] = proc_open('php '. $filename, [], $pipes); | |||
| usleep(30000); | |||
| usleep(300000); | |||
There was a problem hiding this comment.
maybe we can try to connect and sleep between connection and give the hand when the first connection was good ?
|
Thank you for the review. I made a last attempt now. I think the tests will pass. Feel free to merge if so |
|
Thanks, your semaphore name give me another idea if tests are still randomly fail |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests randomly fails time to time trying to increase the the sleep time