WIP: upgrade to HTTPlug 2.0 #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
commented
Dec 2, 2018
dbu
commented
Dec 2, 2018
dbu
force-pushed
the
upgrade-version-2
branch
4 times, most recently
from
c7276fb to
e785e9e
Compare
Nyholm
force-pushed
the
upgrade-version-2
branch
from
e785e9e to
d7a729a
Compare
Nyholm
reviewed
Dec 30, 2018
| */ | ||
| public function setDefaultException(\Exception $defaultException = null) | ||
| public function setDefaultException(?\Exception $defaultException) |
There was a problem hiding this comment.
Good!
We should not allow someone doing $e->setDefaultException();
This change make sure you have to do $e->setDefaultException(null);
Merged
|
Yes, I took this PR and reverted all things that broke BC |
dbu
changed the title
4 tasks
dbu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Some BC breaking changes that clean up the mock client. To be merged when we want to start with version 2.
Checklist