-
Notifications
You must be signed in to change notification settings - Fork 39
Improve package #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve package #48
Conversation
@php-http/owners any idea why StyleCI suddenly gone mad? /cc @GrahamCampbell |
StyleCI is doing one build for a PR, and one for a push, exactly like Travis does. See https://blog.alt-three.com/new-pr-analysis-system/ for more details. |
@GrahamCampbell analysis was okay until yesterday, now it wants to remove trailing period from docblocks: https://styleci.io/repos/48317882 |
Ah, right. That's a change to the symfony CS. They made this change in their codebase very recently, and our rules have been updated accordingly. |
I actually forgot to regen our docs website after the last deploy. I'll do that now! |
Do you have a PR/link where they introduced this change? Just for reference in our boilerplate and I would like to see some reasoning too if any. Thanks. |
Of course. Here you are: symfony/symfony#19198. |
That said, it does look like they specifically are only removing the dots from param and return annotations. I will look into this. |
Thanks for the quick response. |
What's in this PR?
Improve some package files.