Skip to content

Improve package #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2016
Merged

Improve package #48

merged 3 commits into from
Jul 15, 2016

Conversation

sagikazarmark
Copy link
Member

@sagikazarmark sagikazarmark commented Jul 15, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

Improve some package files.

@sagikazarmark
Copy link
Member Author

@php-http/owners any idea why StyleCI suddenly gone mad?

/cc @GrahamCampbell

@GrahamCampbell
Copy link
Contributor

StyleCI is doing one build for a PR, and one for a push, exactly like Travis does.

See https://blog.alt-three.com/new-pr-analysis-system/ for more details.

@sagikazarmark
Copy link
Member Author

@GrahamCampbell analysis was okay until yesterday, now it wants to remove trailing period from docblocks: https://styleci.io/repos/48317882

@GrahamCampbell
Copy link
Contributor

Ah, right. That's a change to the symfony CS. They made this change in their codebase very recently, and our rules have been updated accordingly.

@GrahamCampbell
Copy link
Contributor

I actually forgot to regen our docs website after the last deploy. I'll do that now!

@sagikazarmark
Copy link
Member Author

Do you have a PR/link where they introduced this change? Just for reference in our boilerplate and I would like to see some reasoning too if any. Thanks.

@GrahamCampbell
Copy link
Contributor

Of course. Here you are: symfony/symfony#19198.

@GrahamCampbell
Copy link
Contributor

That said, it does look like they specifically are only removing the dots from param and return annotations. I will look into this.

@sagikazarmark
Copy link
Member Author

Thanks for the quick response.

@sagikazarmark sagikazarmark merged commit a69d952 into master Jul 15, 2016
@sagikazarmark sagikazarmark deleted the improve_package branch July 15, 2016 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants