Updated docs for the bundle #94
Conversation
Nyholm
force-pushed
the
symfony_bundle_2
branch
from
b594d56 to
b8971bd
Compare
|
Not sure if putting full config on a separate page is a good idea. |
|
Okey, I thought the page would be too long otherwise. I move it. I have a question about "integration with other bundles". I do not agree with what our documentation says. That will not allow a user to change client in an easy way. I've done like this in a few projects: https://github.com/Happyr/TranslationBundle#default-configuration But Im not sure that is a good best practice either. |
|
Well, can be a separate page, but in a deeper level then. Other integrations might be in this section as well. integration with other bundles? Where is it? |
|
What I did was a copy paste from the bundle README. Doesn't mean we cannot write better documentation. 😉 |
|
I started php-http/HttplugBundle#58 for this discussion. |
|
i am +1 for having a separate configuration reference page that is not part of the documentation. the reference must list each option and its meanings. the other page should explain the common use cases. those two things are different. |
|
|
||
| Install the Httplug bundle with composer and enabled it in your AppKernel.php. |
| @@ -80,10 +66,11 @@ By default we use Puli to auto discover factories. If you do not want to use aut | |||
| stream_factory: Http\Message\StreamFactory\GuzzleStreamFactory | |||
|
|
|||
|
|
|||
|
|
|||
| Configure your client | |||
There was a problem hiding this comment.
"Configure Clients"
(and all non-glue words in titel are capitalized)
|
cool. lets wrap this up asap and then merge. |
|
Wow, cool thing @dbu. Wanna do the fixes yourself? |
|
i might find a moment tomorrow if tobias does not have the time |
|
Sorry, read your comments now. Im doing some fixes now. |
|
This PR is ready to be merged into #93 |
Updated docs for the bundle
No description provided.