Bugfixes #71
Merged
Bugfixes #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,7 +110,7 @@ private static function storeInCache($type, $class) | |||
| /** | |||
| * Set new strategies and clear the cache. | |||
| * | |||
| * @param DiscoveryStrategy[] $strategies | |||
| * @param array $strategies string array of FQN to a DiscoveryStrategy | |||
There was a problem hiding this comment.
i'd prefer to write it out anyways :-)
@param string[] $strategies Fully qualified class name to a DiscoveryStrategy
| */ | ||
| public static function prependStrategy(DiscoveryStrategy $strategy) | ||
| public static function prependStrategy($strategy) |
There was a problem hiding this comment.
maybe a full functional test with a prepend strategy that returns a mock?
|
LGTM! |
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for this PR. I've made some mistakes in previous PRs.
Fix 1:
We should see if the candidate got a condition when we fetch it from the cache.
Fix 2:
Improved the doc blocs
Fix 3:
We should not require an object of type
DiscoveryStrategyonappendStrateyandprependStrategy. We should require a string FQCN.