[Profiler] Utilize symfony/var-dumper for dumping response body #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symfony also added getContainer method and they clash
ostrolucky
changed the title
|
thanks! do you plan to work on fixing the ci setup of the bundle? (i guess we should port it to github actions like we did for other php-http repositories...) while this looks good to me, i'd prefer to see the CI running through before merging ;-) |
|
CI is running, see https://app.travis-ci.com/github/ostrolucky/HttplugBundle/builds. But yes, I plan to move it to GH actions. |
|
oh, github showed travis-ci as outstanding. looks good then, i merged the change. i let you decide when to tag a release ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Similarly like
symfony/http-clientand other bundles, this utilizessymfony/var-dumperto format request/response body messages.Json detection was partially taken over from csa/guzzle-bundle
This results in much improved design of body formatting, replacing plain nl2br that was used till now.
Checklist