Skip to content

Change default transport to 'null' which does not require any dependencies after install #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2018
Merged

Change default transport to 'null' which does not require any dependencies after install #3

merged 2 commits into from
Oct 27, 2018

Conversation

igrybkov
Copy link
Contributor

@igrybkov igrybkov commented Oct 26, 2018

Right after installation, any console command shows an exception (not only enqueue's, just php bin/magento would be enough):

Symfony\Component\Config\Definition\Exception\InvalidConfigurationException

Invalid configuration for path "enqueue.transport.rabbitmq_amqp": In order to use the transport "rabbitmq_amqp" install one of the packages "enqueue/amqp-ext", "enqueue/amqp-bunny", "enqueue/amqp-lib"

It's incorrect behavior after module installation, especially in case you didn't want to use AMQP at all.
That's why I'm adding a null transport which could be declared without any dependencies and could be switched to a real one when its configuration would be provided and dependencies are installed.

@makasim makasim merged commit 8867586 into php-enqueue:master Oct 27, 2018
@rjshnautiyal
Copy link

In Magento 2.3.4 version, It is giving below error on bin/magento run:
In EnqueueManager.php line 148:

Unknown transport: ""

Please let me know what may be the issue?

@igrybkov
Copy link
Contributor Author

igrybkov commented Aug 24, 2020

@rjshnautiyal, I have no idea. You probably should take a debugger and figure it out.
Once you'll find it, please create an issue in https://github.com/php-enqueue/enqueue-dev/issues or PR here to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants