Sort constants in alphabetical order #771

GiBg1aN · 2017-12-24T15:32:43Z

I found this trivial abandoned PR, so did it from scratch. (Addressed to #622)

mystamps-bot · 2017-12-24T15:42:17Z

	1 Message
📖	@GiBg1aN thank you for the PR! All quality checks have been passed! Next step is to wait when @php-coder will review this code

Generated by 🚫 Danger

codecov · 2017-12-24T15:43:08Z

Codecov Report

Merging #771 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #771   +/-   ##
=========================================
  Coverage     79.38%   79.38%           
  Complexity      448      448           
=========================================
  Files            28       28           
  Lines          1232     1232           
  Branches        173      173           
=========================================
  Hits            978      978           
  Misses          240      240           
  Partials         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06522e9...e5cefd4. Read the comment docs.

php-coder · 2017-12-24T16:12:40Z

Hi, Thank you for this PR! I’m on holidays now and can’t review or merge it from my phone. I’ll look at it in 3 days.

…

-- Slava Semushin

php-coder · 2017-12-27T22:51:25Z

src/main/java/ru/mystamps/web/Url.java

@@ -128,33 +128,34 @@ private Url() {
 		boolean serveContentFromSingleHost = !production;

 		// Not all URLs are listed here but only those that are being used on views
+		// Constant sorted in ascending order


Could you modify it to "Constants sorted in an ascending order." ?

php-coder

The change looks good but I'd like to modify the comments just a bit. Could you update all the comments? Thanks!

GiBg1aN · 2017-12-28T08:35:17Z

Yeah, you are right, I just fixed them.

php-coder

Could you also sort constants and add a comment here:

mystamps/src/main/java/ru/mystamps/web/Url.java

Lines 160 to 171 in 7d3776d

    
           map.put("BOOTSTRAP_CSS", BOOTSTRAP_CSS); 
        
           map.put("BOOTSTRAP_JS", BOOTSTRAP_JS); 
        
           map.put("JQUERY_JS", JQUERY_JS); 
        
           map.put("SELECTIZE_CSS", SELECTIZE_CSS); 
        
           map.put("SELECTIZE_JS", SELECTIZE_JS); 
        
           map.put("GET_IMAGE_PAGE", GET_IMAGE_PAGE); 
        
           map.put("GET_IMAGE_PREVIEW_PAGE", GET_IMAGE_PREVIEW_PAGE); 
        
           map.put("FAVICON_ICO", FAVICON_ICO); 
        
           map.put("MAIN_CSS", MAIN_CSS); 
        
           map.put("CATALOG_UTILS_JS", CATALOG_UTILS_JS); 
        
           map.put("SERIES_ADD_JS", SERIES_ADD_JS); 
        
           map.put("COLLECTION_INFO_JS", COLLECTION_INFO_JS);

and there:

mystamps/src/main/java/ru/mystamps/web/Url.java

Lines 173 to 180 in 7d3776d

    
           // Use a separate domain for our own resources 
        
           map.put("GET_IMAGE_PAGE", STATIC_RESOURCES_URL + GET_IMAGE_PAGE); 
        
           map.put("GET_IMAGE_PREVIEW_PAGE", STATIC_RESOURCES_URL + GET_IMAGE_PREVIEW_PAGE); 
        
           map.put("FAVICON_ICO", STATIC_RESOURCES_URL + FAVICON_ICO); 
        
           map.put("MAIN_CSS", STATIC_RESOURCES_URL + MAIN_CSS); 
        
           map.put("CATALOG_UTILS_JS", STATIC_RESOURCES_URL + CATALOG_UTILS_JS); 
        
           map.put("SERIES_ADD_JS", STATIC_RESOURCES_URL + SERIES_ADD_JS); 
        
           map.put("COLLECTION_INFO_JS", STATIC_RESOURCES_URL + COLLECTION_INFO_JS);

Thanks in advance!

GiBg1aN · 2017-12-30T20:49:34Z

Done, check it out

php-coder · 2017-12-30T21:39:35Z

Merged in 78e9e94 commit.

Thanks!

php-coder · 2017-12-30T21:41:25Z

@GiBg1aN Let me know if you need more tasks like this one.

GiBg1aN requested a review from php-coder as a code owner December 24, 2017 15:32

GiBg1aN changed the title ~~Addressed to #622~~ Sort constants in alphabetical order (Addressed to #622) Dec 24, 2017

php-coder changed the title ~~Sort constants in alphabetical order (Addressed to #622)~~ Sort constants in alphabetical order Dec 27, 2017

php-coder reviewed Dec 27, 2017

View reviewed changes

php-coder requested changes Dec 27, 2017

View reviewed changes

php-coder requested changes Dec 28, 2017

View reviewed changes

Sort constants in alphabetical order

e5cefd4

php-coder approved these changes Dec 30, 2017

View reviewed changes

php-coder closed this Dec 30, 2017

php-coder added the resolution/merged label Dec 30, 2017

GiBg1aN deleted the gh622_sorted_constants branch December 30, 2017 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Sort constants in alphabetical order #771

Sort constants in alphabetical order #771

Uh oh!

GiBg1aN commented Dec 24, 2017 •

edited

Loading

Uh oh!

mystamps-bot commented Dec 24, 2017 •

edited

Loading

Uh oh!

codecov bot commented Dec 24, 2017 •

edited

Loading

Uh oh!

php-coder commented Dec 24, 2017 via email •

edited

Loading

Uh oh!

php-coder Dec 27, 2017

Uh oh!

php-coder left a comment

Uh oh!

GiBg1aN commented Dec 28, 2017

Uh oh!

php-coder left a comment

Uh oh!

GiBg1aN commented Dec 30, 2017

Uh oh!

php-coder commented Dec 30, 2017

Uh oh!

php-coder commented Dec 30, 2017

Uh oh!

Uh oh!

	map.put("BOOTSTRAP_CSS", BOOTSTRAP_CSS);
	map.put("BOOTSTRAP_JS", BOOTSTRAP_JS);
	map.put("JQUERY_JS", JQUERY_JS);
	map.put("SELECTIZE_CSS", SELECTIZE_CSS);
	map.put("SELECTIZE_JS", SELECTIZE_JS);
	map.put("GET_IMAGE_PAGE", GET_IMAGE_PAGE);
	map.put("GET_IMAGE_PREVIEW_PAGE", GET_IMAGE_PREVIEW_PAGE);
	map.put("FAVICON_ICO", FAVICON_ICO);
	map.put("MAIN_CSS", MAIN_CSS);
	map.put("CATALOG_UTILS_JS", CATALOG_UTILS_JS);
	map.put("SERIES_ADD_JS", SERIES_ADD_JS);
	map.put("COLLECTION_INFO_JS", COLLECTION_INFO_JS);

	// Use a separate domain for our own resources
	map.put("GET_IMAGE_PAGE", STATIC_RESOURCES_URL + GET_IMAGE_PAGE);
	map.put("GET_IMAGE_PREVIEW_PAGE", STATIC_RESOURCES_URL + GET_IMAGE_PREVIEW_PAGE);
	map.put("FAVICON_ICO", STATIC_RESOURCES_URL + FAVICON_ICO);
	map.put("MAIN_CSS", STATIC_RESOURCES_URL + MAIN_CSS);
	map.put("CATALOG_UTILS_JS", STATIC_RESOURCES_URL + CATALOG_UTILS_JS);
	map.put("SERIES_ADD_JS", STATIC_RESOURCES_URL + SERIES_ADD_JS);
	map.put("COLLECTION_INFO_JS", STATIC_RESOURCES_URL + COLLECTION_INFO_JS);

Sort constants in alphabetical order #771

Sort constants in alphabetical order #771

Uh oh!

Conversation

GiBg1aN commented Dec 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mystamps-bot commented Dec 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Dec 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

php-coder commented Dec 24, 2017 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

php-coder Dec 27, 2017

Choose a reason for hiding this comment

Uh oh!

php-coder left a comment

Choose a reason for hiding this comment

Uh oh!

GiBg1aN commented Dec 28, 2017

Uh oh!

php-coder left a comment

Choose a reason for hiding this comment

Uh oh!

GiBg1aN commented Dec 30, 2017

Uh oh!

php-coder commented Dec 30, 2017

Uh oh!

php-coder commented Dec 30, 2017

Uh oh!

Uh oh!

GiBg1aN commented Dec 24, 2017 •

edited

Loading

mystamps-bot commented Dec 24, 2017 •

edited

Loading

codecov bot commented Dec 24, 2017 •

edited

Loading

php-coder commented Dec 24, 2017 via email •

edited

Loading