-
Notifications
You must be signed in to change notification settings - Fork 34
Sorted constants in alphabetically order #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you! I left a couple of comments but overall it looks good to me.
Also I see that you use your name as an author for the commit. Generally I advise to use a real name (but it's not required of course). So, consider updating the author value in the commit (git commit user.name "John Dow" && git commit --am --reset-author).
BTW how did you find this project?
@@ -120,29 +120,29 @@ private Url() { | |||
public static Map<String, String> asMap(boolean serveContentFromSingleHost) { | |||
// There is not all urls but only those which used on views | |||
Map<String, String> map = new HashMap<>(); | |||
map.put("PUBLIC_URL", PUBLIC_URL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a comment here?
@@ -76,12 +76,12 @@ | |||
if (userDetails.isAdmin()) { | |||
authorities.add(Authority.ADD_COMMENTS_TO_SERIES); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a comment here and above?
Thanks for the comments! This is my first time trying out GitHub, so I was searching for some trivial bug fixes to get started with and found this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments from a bot:
- trailing space should be removed
- there should be only single commit (not 3)
@sagorika1996 Hi, do you have plans to fix my comments or you aren't interested in anymore? |
@sagorika1996 Hi, I don't want to reject your PR but I also can't merge it because it contains 4 commits (instead of 1) and there are couple trivial comments that should be addressed. Please, try to fix them and I'd be happy to accept your contribution! |
I'm sorry I can't accept this PR because my comments weren't fixed. If it was a single commit, I would probably merge it. But it has 4 commits for such a trivial change and also I'll need to fix minor issues by myself after that. So I feel that it doesn't worth it. |
Addressed to #622