Skip to content

Address to #1345 #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Address to #1345 #1359

wants to merge 1 commit into from

Conversation

splin-shady
Copy link

No description provided.

@splin-shady splin-shady requested a review from php-coder as a code owner April 21, 2020 13:48
@mystamps-bot
Copy link

16 Errors
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/misc.robot#L10-L15:
Test case Country name should be stripped from leading and trailing spaces fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/misc.robot#L17-L22:
Test case Country name should be modified by replacing multiple spaces by one fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/misc.robot#L24-L29:
Test case Country name in English should accept all allowed characters fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/misc.robot#L31-L36:
Test case Country name in Russian should accept all allowed characters fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L10-L15:
Test case Create country with too short name fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L17-L24:
Test case Create country with too long name fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L26-L31:
Test case Create country with forbidden characters in name fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L33-L38:
Test case Create country with repeating hyphens in name fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L40-L45:
Test case Create country with name that starts with hyphen fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L47-L52:
Test case Create country with name that ends with hyphen fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L54-L59:
Test case Create country with existing (non-unique) name fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L61-L66:
Test case Create country with existing name but in a different case fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L68-L73:
Test case Create country with non-existing name but existing (non-unique) slug fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/validation.robot#L75-L85:
Test case Create country with forbidden names fails with message:
Parent suite setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/logic.robot#L12-L19:
Test case Create country with name in English (fill only mandatory fields) fails with message:
Setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
🚫 robotframework-maven-plugin error in src/test/robotframework/country/creation/logic.robot#L21-L28:
Test case Create country with name in English and Russian fails with message:
Setup failed:
com.gargoylesoftware.htmlunit.ScriptException: ReferenceError: “AddCountryForm” is not defined. (script in http://127.0.0.1:8080/country/add from (78, 11) to (80, 12)#79)
1 Warning
⚠️ danger check: pull request description doesn’t contain a link to original issue.
Consider adding a comment in the following format: Addressed to #XXX where XXX is an issue number
1 Message
📖 robotframework-maven-plugin reported about 16 errors. Please, fix them. See also: https://github.com/php-coder/mystamps/wiki/integration-tests

Generated by 🚫 Danger

@php-coder
Copy link
Owner

@splin-shady Thank you for the PR! Why you closed it?

php-coder
php-coder reviewed Apr 21, 2020
View reviewed changes
src/main/webapp/WEB-INF/views/country/add.html
@@ -73,43 +73,8 @@ <h3 th:text="${#strings.capitalize(add_country)}">
</small>
</div>

<form id="add-country-form" method="post" class="form-horizontal" action="info.html"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shouldn't remove the existing form. React component just should be rendered to the same element.

src/main/webapp/WEB-INF/views/country/add.html

<script src="../../../../../../target/classes/js/components/AddCountryForm.js"></script>
<script th:inline="javascript">
ReactDOM.render(React.createElement(AddCountryForm), document.getElementById('add-country-form-react'));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's render into add-country-form

@php-coder
Copy link
Owner

Duplicate of #1360

@php-coder php-coder marked this as a duplicate of #1360 Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder left review comments

Assignees
No one assigned
Labels
resolution/duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@splin-shady @mystamps-bot @php-coder