Skip to content

{Category,Country}ServiceImpl: properly handle special characters #682

Open
@php-coder

Description

@php-coder

We should resolve the following TODOs:

public List<Integer> findIdsWhenNameStartsWith(String name) {
Validate.isTrue(StringUtils.isNotBlank(name), "Name must be non-blank");
// TODO: escape % and _ chars in name
Validate.isTrue(
!StringUtils.containsAny(name, '%', '_'),
"Name must not contain '%' or '_' chars"
);
return categoryDao.findIdsByNamePattern(name + '%');
}

and

public List<Integer> findIdsWhenNameStartsWith(String name) {
Validate.isTrue(StringUtils.isNotBlank(name), "Name must be non-blank");
// TODO: escape % and _ chars in name
Validate.isTrue(
!StringUtils.containsAny(name, '%', '_'),
"Name must not contain '%' or '_' chars"
);
return countryDao.findIdsByNamePattern(name + '%');
}

Tech debt for 29f6dc9 (#660)

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions