Use uncrustify for formatting #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesfrain
commented
Mar 23, 2021
| sudo apt-get install spell | ||
| sudo apt-get install util-linux | ||
| sudo apt install spell util-linux uncrustify |
There was a problem hiding this comment.
This was a lazy attempt to make uncrustify available to the other CI steps, which didn't work. Determining the right way to do this will require more digging, which I'm not going to get around to any time soon.
There was a problem hiding this comment.
Each workflow file gets run in a separate container. You probably meant to add this to .github/workflows/pre-commit.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't apply formatting rules to all file types (e.g. .md, etc).
I also found this stalls in the
portabledirectory when trying to apply this to everything with:There might be ways to avoid duplicating the formatting config file from the tools directory. https://github.com/FreeRTOS/FreeRTOS/blob/master/tools/uncrustify.cfg