Include grpc port in about #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nitisht merged 1 commit into parseablehq:main from trueleo:about-grpc

Oct 18, 2023

Contributor

trueleo commented Oct 18, 2023

Fixes #XXXX.

Description

About json now contains grpc port number. This combined with hostname will result in url for grpc service

This PR has:

been tested to ensure log ingestion and log query works.
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added documentation for new or modified features or behaviors.


          Include grpc port in about

1c4e3ba

nitisht merged commit 66628a8 into parseablehq:main

github-actions bot locked and limited conversation to collaborators

trueleo deleted the about-grpc branch

October 26, 2023 07:22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet