Skip to content

Remove the env var and cli option for memory only ingestion #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified helm-releases/operator-0.0.2.tgz
Binary file not shown.
Binary file added helm-releases/parseable-0.4.5.tgz
Binary file not shown.
4 changes: 2 additions & 2 deletions helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: parseable
description: Helm chart for Parseable Server
type: application
version: 0.4.4
appVersion: "v0.4.3"
version: 0.4.5
appVersion: "v0.4.4"
maintainers:
- name: Parseable Team
email: [email protected]
Expand Down
2 changes: 1 addition & 1 deletion helm/values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
parseable:
image:
repository: parseable/parseable
tag: v0.4.3
tag: v0.4.4
pullPolicy: Always
## Set to true if you want to deploy Parseable in local mode (store logs
## on local mount point instead of S3 bucket)
Expand Down
67 changes: 45 additions & 22 deletions index.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ entries:
operator:
- apiVersion: v2
appVersion: v0.0.2
created: "2023-05-03T11:32:39.068803+05:30"
created: "2023-05-18T10:51:00.514519+05:30"
description: A Helm chart for Parseable Operator
digest: 7dd638ce20b271cac2f92aad7e1760eb4d961fe43aa24914ba100b8f34219956
digest: 0bf4cd8cc7f1c5ff6d49f91fe91204855a215ae1cb5acaeb3fe84497bc97c566
name: operator
type: application
urls:
- https://charts.parseable.io/helm-releases/operator-0.0.2.tgz
version: 0.0.2
- apiVersion: v2
appVersion: 0.0.1
created: "2023-05-03T11:32:39.067244+05:30"
created: "2023-05-18T10:51:00.513223+05:30"
description: A Helm chart for Parseable Operator
digest: 344cedd9e3a0f17c6ff09514dabed994bac7bac94ace500857d487c1c9cc1859
name: operator
Expand All @@ -33,9 +33,32 @@ entries:
- https://charts.parseable.io/helm-releases/operator-0.0.1.tgz
version: 0.0.1
parseable:
- apiVersion: v2
appVersion: v0.4.4
created: "2023-05-18T10:51:00.562837+05:30"
dependencies:
- condition: vector.enabled
name: vector
repository: https://helm.vector.dev
version: 0.20.1
- condition: fluent-bit.enabled
name: fluent-bit
repository: https://fluent.github.io/helm-charts
version: 0.25.0
description: Helm chart for Parseable Server
digest: c25a992b29370b577bfaaac09ba83db708da115ceaa3f2870f68e29e301aa5ce
maintainers:
- email: [email protected]
name: Parseable Team
url: https://parseable.io
name: parseable
type: application
urls:
- https://charts.parseable.io/helm-releases/parseable-0.4.5.tgz
version: 0.4.5
- apiVersion: v2
appVersion: v0.4.3
created: "2023-05-03T11:32:39.112333+05:30"
created: "2023-05-18T10:51:00.557482+05:30"
dependencies:
- condition: vector.enabled
name: vector
Expand All @@ -58,7 +81,7 @@ entries:
version: 0.4.4
- apiVersion: v2
appVersion: v0.4.2
created: "2023-05-03T11:32:39.10879+05:30"
created: "2023-05-18T10:51:00.552296+05:30"
dependencies:
- condition: vector.enabled
name: vector
Expand All @@ -81,7 +104,7 @@ entries:
version: 0.4.3
- apiVersion: v2
appVersion: v0.4.1
created: "2023-05-03T11:32:39.103831+05:30"
created: "2023-05-18T10:51:00.547111+05:30"
dependencies:
- condition: vector.enabled
name: vector
Expand All @@ -104,7 +127,7 @@ entries:
version: 0.4.2
- apiVersion: v2
appVersion: v0.4.0
created: "2023-05-03T11:32:39.098125+05:30"
created: "2023-05-18T10:51:00.541548+05:30"
dependencies:
- condition: vector.enabled
name: vector
Expand All @@ -127,7 +150,7 @@ entries:
version: 0.4.1
- apiVersion: v2
appVersion: v0.4.0
created: "2023-05-03T11:32:39.09345+05:30"
created: "2023-05-18T10:51:00.536763+05:30"
dependencies:
- condition: vector.enabled
name: vector
Expand All @@ -150,7 +173,7 @@ entries:
version: 0.4.0
- apiVersion: v2
appVersion: v0.3.1
created: "2023-05-03T11:32:39.088173+05:30"
created: "2023-05-18T10:51:00.531052+05:30"
dependencies:
- condition: vector.enabled
name: vector
Expand All @@ -173,7 +196,7 @@ entries:
version: 0.3.1
- apiVersion: v2
appVersion: v0.3.0
created: "2023-05-03T11:32:39.08183+05:30"
created: "2023-05-18T10:51:00.524675+05:30"
description: Helm chart for Parseable Server
digest: ff30739229b727dc637f62fd4481c886a6080ce4556bae10cafe7642ddcfd937
name: parseable
Expand All @@ -183,7 +206,7 @@ entries:
version: 0.3.0
- apiVersion: v2
appVersion: v0.2.2
created: "2023-05-03T11:32:39.080995+05:30"
created: "2023-05-18T10:51:00.523713+05:30"
description: Helm chart for Parseable Server
digest: 477d0dc2f0c07d4f4c32e105d4bdd70c71113add5c2a75ac5f1cb42aa0276db7
name: parseable
Expand All @@ -193,7 +216,7 @@ entries:
version: 0.2.2
- apiVersion: v2
appVersion: v0.2.1
created: "2023-05-03T11:32:39.079699+05:30"
created: "2023-05-18T10:51:00.52243+05:30"
description: Helm chart for Parseable Server
digest: 84826fcd1b4c579f301569f43b0309c07e8082bad76f5cdd25f86e86ca2e8192
name: parseable
Expand All @@ -203,7 +226,7 @@ entries:
version: 0.2.1
- apiVersion: v2
appVersion: v0.2.0
created: "2023-05-03T11:32:39.078951+05:30"
created: "2023-05-18T10:51:00.521699+05:30"
description: Helm chart for Parseable Server
digest: 7a759f7f9809f3935cba685e904c021a0b645f217f4e45b9be185900c467edff
name: parseable
Expand All @@ -213,7 +236,7 @@ entries:
version: 0.2.0
- apiVersion: v2
appVersion: v0.1.1
created: "2023-05-03T11:32:39.078226+05:30"
created: "2023-05-18T10:51:00.520972+05:30"
description: Helm chart for Parseable Server
digest: 37993cf392f662ec7b1fbfc9a2ba00ec906d98723e38f3c91ff1daca97c3d0b3
name: parseable
Expand All @@ -223,7 +246,7 @@ entries:
version: 0.1.1
- apiVersion: v2
appVersion: v0.1.0
created: "2023-05-03T11:32:39.077409+05:30"
created: "2023-05-18T10:51:00.520245+05:30"
description: Helm chart for Parseable Server
digest: 1d580d072af8d6b1ebcbfee31c2e16c907d08db754780f913b5f0032b403789b
name: parseable
Expand All @@ -233,7 +256,7 @@ entries:
version: 0.1.0
- apiVersion: v2
appVersion: v0.0.8
created: "2023-05-03T11:32:39.076265+05:30"
created: "2023-05-18T10:51:00.519482+05:30"
description: Helm chart for Parseable Server
digest: c805254ffa634f96ecec448bcfff9973339aa9487dd8199b21b17b79a4de9345
name: parseable
Expand All @@ -243,7 +266,7 @@ entries:
version: 0.0.8
- apiVersion: v2
appVersion: v0.0.7
created: "2023-05-03T11:32:39.074884+05:30"
created: "2023-05-18T10:51:00.518556+05:30"
description: Helm chart for Parseable Server
digest: c591f617ed1fe820bb2c72a4c976a78126f1d1095d552daa07c4700f46c4708a
name: parseable
Expand All @@ -253,7 +276,7 @@ entries:
version: 0.0.7
- apiVersion: v2
appVersion: v0.0.6
created: "2023-05-03T11:32:39.073421+05:30"
created: "2023-05-18T10:51:00.517675+05:30"
description: Helm chart for Parseable Server
digest: f9ae56a6fcd6a59e7bee0436200ddbedeb74ade6073deb435b8fcbaf08dda795
name: parseable
Expand All @@ -263,7 +286,7 @@ entries:
version: 0.0.6
- apiVersion: v2
appVersion: v0.0.5
created: "2023-05-03T11:32:39.072589+05:30"
created: "2023-05-18T10:51:00.516993+05:30"
description: Helm chart for Parseable Server
digest: 4d6b08a064fba36e16feeb820b77e1e8e60fb6de48dbf7ec8410d03d10c26ad0
name: parseable
Expand All @@ -273,7 +296,7 @@ entries:
version: 0.0.5
- apiVersion: v2
appVersion: v0.0.2
created: "2023-05-03T11:32:39.071436+05:30"
created: "2023-05-18T10:51:00.51619+05:30"
description: Helm chart for Parseable Server
digest: 38a0a3e4c498afbbcc76ebfcb9cb598fa2ca843a53cc93b3cb4f135b85c10844
name: parseable
Expand All @@ -283,7 +306,7 @@ entries:
version: 0.0.2
- apiVersion: v2
appVersion: v0.0.1
created: "2023-05-03T11:32:39.070198+05:30"
created: "2023-05-18T10:51:00.515418+05:30"
description: Helm chart for Parseable Server
digest: 1f1142db092b9620ee38bb2294ccbb1c17f807b33bf56da43816af7fe89f301e
name: parseable
Expand Down Expand Up @@ -312,4 +335,4 @@ entries:
urls:
- https://charts.parseable.io/helm-releases/parseable-operator-0.0.1.tgz
version: 0.0.1
generated: "2023-05-03T11:32:39.063087+05:30"
generated: "2023-05-18T10:51:00.508745+05:30"
2 changes: 1 addition & 1 deletion server/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "parseable"
version = "0.4.3"
version = "0.4.4"
authors = ["Parseable Team <[email protected]>"]
edition = "2021"
rust-version = "1.67"
Expand Down
18 changes: 0 additions & 18 deletions server/src/option.rs
Original file line number Diff line number Diff line change
Expand Up @@ -178,9 +178,6 @@ pub struct Server {
/// Password for the basic authentication on the server
pub password: String,

/// Server in memory ingestion stratergy
pub in_mem_ingestion: bool,

/// Server should check for update or not
pub check_update: bool,

Expand Down Expand Up @@ -224,10 +221,6 @@ impl FromArgMatches for Server {
.get_one::<String>(Self::PASSWORD)
.cloned()
.expect("default for password");
self.in_mem_ingestion = m
.get_one::<bool>(Self::IN_MEM)
.cloned()
.expect("default for in memory ingestion");
self.check_update = m
.get_one::<bool>(Self::CHECK_UPDATE)
.cloned()
Expand Down Expand Up @@ -268,7 +261,6 @@ impl Server {
pub const UPLOAD_INTERVAL: &str = "upload-interval";
pub const USERNAME: &str = "username";
pub const PASSWORD: &str = "password";
pub const IN_MEM: &str = "in-memory-ingestion";
pub const CHECK_UPDATE: &str = "check-update";
pub const SEND_ANALYTICS: &str = "send-analytics";
pub const ROW_GROUP_SIZE: &str = "row-group-size";
Expand Down Expand Up @@ -350,16 +342,6 @@ impl Server {
.required(true)
.help("Password for the basic authentication on the server"),
)
.arg(
Arg::new(Self::IN_MEM)
.long(Self::IN_MEM)
.env("P_MEMORY_STAGING")
.value_name("BOOL")
.required(false)
.default_value("false")
.value_parser(value_parser!(bool))
.help("Disable/Enable memory based data staging"),
)
.arg(
Arg::new(Self::CHECK_UPDATE)
.long(Self::CHECK_UPDATE)
Expand Down