-
-
Notifications
You must be signed in to change notification settings - Fork 144
fix: alb_log regex #1302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nitisht
merged 6 commits into
parseablehq:main
from
nikhilsinhaparseable:alb-log-regex-fix
Apr 26, 2025
Merged
fix: alb_log regex #1302
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d3c5d15
fix: alb_log regex
nikhilsinhaparseable c390969
update Dockerfile for kafka
nikhilsinhaparseable a12d1f7
update build.yaml for kafka, remove duplicate from converage.yaml
nikhilsinhaparseable e2a3088
fix build for kafka
nikhilsinhaparseable bd32964
update build.yaml
nikhilsinhaparseable 3ab336e
split dependency for macOS and linux
nikhilsinhaparseable File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,11 @@ | ||
name: Ensure parseable builds on all release targets | ||
|
||
on: | ||
pull_request: | ||
paths-ignore: | ||
- "docs/**" | ||
- "helm/**" | ||
- "assets/**" | ||
- docs/** | ||
- helm/** | ||
- assets/** | ||
- "**.md" | ||
|
||
jobs: | ||
# Default build without Kafka | ||
build-default: | ||
|
@@ -30,15 +28,12 @@ jobs: | |
# Windows build | ||
- os: windows-latest | ||
target: x86_64-pc-windows-msvc | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Setup Rust toolchain | ||
uses: dtolnay/rust-toolchain@stable | ||
with: | ||
targets: ${{ matrix.target }} | ||
|
||
- name: Cache dependencies | ||
uses: actions/cache@v4 | ||
with: | ||
|
@@ -47,14 +42,12 @@ jobs: | |
~/.cargo/git | ||
target | ||
key: ${{ runner.os }}-cargo-${{ matrix.target }}-default-${{ hashFiles('**/Cargo.lock') }} | ||
|
||
- name: Build | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
use-cross: ${{ runner.os == 'Linux' }} | ||
command: build | ||
args: --target ${{ matrix.target }} --release | ||
|
||
# Kafka build for supported platforms | ||
build-kafka: | ||
name: Build Kafka ${{matrix.target}} | ||
|
@@ -68,10 +61,8 @@ jobs: | |
target: x86_64-unknown-linux-gnu | ||
- os: macos-latest | ||
target: aarch64-apple-darwin | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
# Linux-specific dependencies | ||
- name: Install Linux dependencies | ||
if: runner.os == 'Linux' | ||
|
@@ -90,7 +81,6 @@ jobs: | |
python3 \ | ||
gcc-aarch64-linux-gnu \ | ||
g++-aarch64-linux-gnu | ||
|
||
# Install cross-compilation specific packages | ||
if [ "${{ matrix.target }}" = "aarch64-unknown-linux-gnu" ]; then | ||
sudo apt-get install -y \ | ||
|
@@ -101,8 +91,6 @@ jobs: | |
libssl-dev:arm64 \ | ||
pkg-config-aarch64-linux-gnu | ||
fi | ||
|
||
|
||
# macOS-specific dependencies | ||
- name: Install macOS dependencies | ||
if: runner.os == 'macOS' | ||
|
@@ -116,12 +104,10 @@ jobs: | |
[email protected] \ | ||
cyrus-sasl \ | ||
python3 | ||
|
||
- name: Setup Rust toolchain | ||
uses: dtolnay/rust-toolchain@stable | ||
with: | ||
targets: ${{ matrix.target }} | ||
|
||
- name: Cache dependencies | ||
uses: actions/cache@v4 | ||
with: | ||
|
@@ -130,7 +116,48 @@ jobs: | |
~/.cargo/git | ||
target | ||
key: ${{ runner.os }}-cargo-${{ matrix.target }}-kafka-${{ hashFiles('**/Cargo.lock') }} | ||
|
||
- name: Find and fix librdkafka CMakeLists.txt for Linux | ||
if: runner.os == 'Linux' | ||
run: | | ||
cargo fetch | ||
# Find the rdkafka-sys package directory | ||
RDKAFKA_SYS_DIR=$(find ~/.cargo/registry/src -name "rdkafka-sys-*" -type d | head -n 1) | ||
echo "Found rdkafka-sys at: $RDKAFKA_SYS_DIR" | ||
# Find the librdkafka CMakeLists.txt file | ||
CMAKE_FILE="$RDKAFKA_SYS_DIR/librdkafka/CMakeLists.txt" | ||
if [ -f "$CMAKE_FILE" ]; then | ||
echo "Found CMakeLists.txt at: $CMAKE_FILE" | ||
# Make a backup of the original file | ||
cp "$CMAKE_FILE" "$CMAKE_FILE.bak" | ||
# Replace the minimum required version | ||
sed -i 's/cmake_minimum_required(VERSION 3.2)/cmake_minimum_required(VERSION 3.5)/' "$CMAKE_FILE" | ||
echo "Modified CMakeLists.txt - before and after comparison:" | ||
diff "$CMAKE_FILE.bak" "$CMAKE_FILE" || true | ||
else | ||
echo "Could not find librdkafka CMakeLists.txt file!" | ||
exit 1 | ||
fi | ||
- name: Find and fix librdkafka CMakeLists.txt for macOS | ||
if: runner.os == 'macOS' | ||
run: | | ||
cargo fetch | ||
# Find the rdkafka-sys package directory | ||
RDKAFKA_SYS_DIR=$(find ~/.cargo/registry/src -name "rdkafka-sys-*" -type d | head -n 1) | ||
echo "Found rdkafka-sys at: $RDKAFKA_SYS_DIR" | ||
# Find the librdkafka CMakeLists.txt file | ||
CMAKE_FILE="$RDKAFKA_SYS_DIR/librdkafka/CMakeLists.txt" | ||
if [ -f "$CMAKE_FILE" ]; then | ||
echo "Found CMakeLists.txt at: $CMAKE_FILE" | ||
# Make a backup of the original file | ||
cp "$CMAKE_FILE" "$CMAKE_FILE.bak" | ||
# Replace the minimum required version - macOS requires '' after -i | ||
sed -i '' 's/cmake_minimum_required(VERSION 3.2)/cmake_minimum_required(VERSION 3.5)/' "$CMAKE_FILE" | ||
echo "Modified CMakeLists.txt - before and after comparison:" | ||
diff "$CMAKE_FILE.bak" "$CMAKE_FILE" || true | ||
else | ||
echo "Could not find librdkafka CMakeLists.txt file!" | ||
exit 1 | ||
fi | ||
- name: Build with Kafka | ||
uses: actions-rs/cargo@v1 | ||
with: | ||
|
@@ -140,9 +167,9 @@ jobs: | |
env: | ||
LIBRDKAFKA_SSL_VENDORED: 1 | ||
PKG_CONFIG_ALLOW_CROSS: "1" | ||
PKG_CONFIG_PATH: "/usr/lib/aarch64-linux-gnu/pkgconfig" | ||
SASL2_DIR: "/usr/lib/aarch64-linux-gnu" | ||
OPENSSL_DIR: "/usr/lib/aarch64-linux-gnu" | ||
OPENSSL_ROOT_DIR: "/usr/lib/aarch64-linux-gnu" | ||
PKG_CONFIG_PATH: /usr/lib/aarch64-linux-gnu/pkgconfig | ||
SASL2_DIR: /usr/lib/aarch64-linux-gnu | ||
OPENSSL_DIR: /usr/lib/aarch64-linux-gnu | ||
OPENSSL_ROOT_DIR: /usr/lib/aarch64-linux-gnu | ||
OPENSSL_STATIC: "1" | ||
SASL2_STATIC: "0" | ||
SASL2_STATIC: "0" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.