Update to coverage #1285
Update to coverage #1285
Conversation
Github action fails because the runner's minimum supported version for CMAKE is 3.5 whereas the minimum version mentioned in `librdkafka` is 3.2 This PR introduces a (hopefully temporary) change which fetches the crates and modifies the `CMakeLists.txt` of `librdkafka` before installation
WalkthroughThe change introduces a new job step in the GitHub Actions workflow defined in Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub as GitHub Actions
participant Shell as Shell Script
participant FS as Filesystem
GitHub->>Shell: Execute new job step
Shell->>FS: Run `cargo fetch`
Shell->>FS: Locate `rdkafka-sys` package directory
alt File found
Shell->>FS: Create backup of `CMakeLists.txt`
Shell->>FS: Update CMake version from 3.2 to 3.5 using sed
Shell->>GitHub: Output diff of file changes
else File not found
Shell->>GitHub: Print error and exit (status 1)
end
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
.github/workflows/coverage.yaml (7)
36-36: Nitpick: Remove trailing whitespaceTrailing whitespace is present on this blank line. Removing extra spaces helps maintain clean YAML formatting and prevents linting errors.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 36-36: trailing spaces
(trailing-spaces)
41-41: Nitpick: Remove trailing whitespaceExtra spaces detected at the end of this line. Please remove them to conform with YAML lint standards.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 41-41: trailing spaces
(trailing-spaces)
45-45: Nitpick: Remove trailing whitespaceTrailing spaces found on this line. Removing these unnecessary whitespaces will improve file consistency.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 45-45: trailing spaces
(trailing-spaces)
48-48: Nitpick: Remove trailing whitespaceThis line contains trailing whitespace. Consider trimming the extra spaces for better formatting.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 48-48: trailing spaces
(trailing-spaces)
51-51: Nitpick: Remove trailing whitespaceTrailing whitespace detected here. Cleaning up these spaces helps avoid YAML lint errors.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 51-51: trailing spaces
(trailing-spaces)
54-54: Nitpick: Remove trailing whitespaceExtra whitespace is present at the end of this line. Please remove it to adhere to formatting guidelines.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 54-54: trailing spaces
(trailing-spaces)
57-57: Nitpick: Remove trailing whitespaceTrailing spaces found on this line. Removing them will help maintain a clean codebase.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 57-57: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/coverage.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/coverage.yaml
[error] 36-36: trailing spaces
(trailing-spaces)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
[error] 48-48: trailing spaces
(trailing-spaces)
[error] 51-51: trailing spaces
(trailing-spaces)
[error] 54-54: trailing spaces
(trailing-spaces)
[error] 57-57: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: coverage
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
🔇 Additional comments (1)
.github/workflows/coverage.yaml (1)
37-63: Temporary Fix for librdkafka CMakeLists.txtThe new job step efficiently handles compatibility issues by:
- Fetching the necessary Rust package using
cargo fetch.- Locating the
rdkafka-syspackage directory.- Backing up the original
CMakeLists.txt.- Using
sedto update the minimum required CMake version from 3.2 to 3.5.This workaround is a solid temporary solution to the CMake version mismatch issue encountered during GitHub Actions runs. It would be helpful to add an inline comment or documentation note explaining that this is a temporary patch until the upstream
librdkafkais updated.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 41-41: trailing spaces
(trailing-spaces)
[error] 45-45: trailing spaces
(trailing-spaces)
[error] 48-48: trailing spaces
(trailing-spaces)
[error] 51-51: trailing spaces
(trailing-spaces)
[error] 54-54: trailing spaces
(trailing-spaces)
[error] 57-57: trailing spaces
(trailing-spaces)
Github action fails because the runner's minimum supported version for CMAKE is 3.5 whereas the minimum version mentioned in
librdkafkais 3.2 This PR introduces a (hopefully temporary) change which fetches the crates and modifies theCMakeLists.txtoflibrdkafkabefore installationFixes #XXXX.
Description
This PR has:
Summary by CodeRabbit