-
-
Notifications
You must be signed in to change notification settings - Fork 142
fix: file pruning with notEq operator #1249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
current: all files get pruned in query for notEq operator because of incorrect condition match fix: with notEq, we cannot determine if the file can be pruned hence, removed the check
WalkthroughThe change removes the handling of the Changes
Sequence Diagram(s)sequenceDiagram
participant QP as Query Processor
participant SSP as StreamSchemaProvider
QP->>SSP: Call satisfy_constraints(value, operator, min, max)
alt operator is not NotEq
SSP->>SSP: Evaluate logic for Eq, Lt, LtEq, Gt, GtEq
else operator is NotEq
SSP->>SSP: Proceed without a specific NotEq branch
end
SSP-->>QP: Return evaluation result
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
current: all files get pruned in query for notEq operator because of incorrect condition match
fix: with notEq, we cannot determine if the file can be pruned hence, removed the check
Summary by CodeRabbit