fix: file pruning with notEq operator

[nikhilsinhaparseable]

current: all files get pruned in query for notEq operator because of incorrect condition match

fix: with notEq, we cannot determine if the file can be pruned hence, removed the check

Summary by CodeRabbit

• Bug Fixes
  • Improved filtering behavior by refining how inequality conditions are evaluated, ensuring more consistent results when applying non-equality constraints.

[coderabbitai]

Walkthrough

The change removes the handling of the Operator::NotEq case in the satisfy_constraints function within the stream schema provider module. The previous logic for NotEq, which checked if a value was less than the minimum and greater than the maximum, has been eliminated. All other operator branches (Eq, Lt, LtEq, Gt, GtEq) remain intact. No modifications were made to the exported or public entities.

Changes

File(s)	Change Summary
src/query/stream_schema_provider.rs	Removed specific handling for Operator::NotEq (i.e., the condition checking value < min && value > max) in the satisfy_constraints function. Other operator cases remain unchanged.

Sequence Diagram(s)

sequenceDiagram
    participant QP as Query Processor
    participant SSP as StreamSchemaProvider
    QP->>SSP: Call satisfy_constraints(value, operator, min, max)
    alt operator is not NotEq
        SSP->>SSP: Evaluate logic for Eq, Lt, LtEq, Gt, GtEq
    else operator is NotEq
        SSP->>SSP: Proceed without a specific NotEq branch
    end
    SSP-->>QP: Return evaluation result

Loading

Poem

Oh hop, oh hop, a change is in play,
The NotEq path has hopped away.
Code fields pruned with a careful snip,
Logical streams now take a new trip.
A joyful nibble from a coder’s treat—
Debugging hops on tiny feet! 🐇🥕

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 160dec4 and be4aa2b.

📒 Files selected for processing (1)

• src/query/stream_schema_provider.rs (0 hunks)

💤 Files with no reviewable changes (1)

• src/query/stream_schema_provider.rs

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: coverage
• GitHub Check: Quest Smoke and Load Tests for Distributed deployments
• GitHub Check: Quest Smoke and Load Tests for Standalone deployments
• GitHub Check: Build Default aarch64-apple-darwin
• GitHub Check: Build Default x86_64-unknown-linux-gnu
• GitHub Check: Build Default x86_64-pc-windows-msvc
• GitHub Check: Build Default aarch64-unknown-linux-gnu
• GitHub Check: Build Kafka aarch64-apple-darwin
• GitHub Check: Build Kafka x86_64-unknown-linux-gnu
• GitHub Check: Build Default x86_64-apple-darwin

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.