Skip to content

fix: prism home api #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

nikhilsinhaparseable
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable commented Mar 17, 2025

  1. add critical severity alert count to alerts info
  2. date level stats in sorted order

Summary by CodeRabbit

  • New Features
    • The alert system now tracks and displays the count of high-severity alerts.
    • The home section now presents dates in reverse order, ensuring the most recent dates appear first.

1. add critical severity alert count to alerts info
2. date level stats in sorted order
Copy link
Contributor

coderabbitai bot commented Mar 17, 2025

Walkthrough

This pull request introduces two primary changes. In the alerts module, it adds a new critical field to the AlertsInfo struct and updates the alert processing loop to count critical alerts. In the home module, it modifies the generate_home_response function by making the dates variable mutable and reversing the generated list of date strings before further processing.

Changes

File(s) Change Summary
src/alerts/mod.rs - Added critical: u64 field to AlertsInfo
- Initialized let mut critical = 0 in get_alerts_info
- Updated loop to increment critical for Severity::Critical alerts
- Included critical count in the returned struct
src/prism/home/mod.rs - Changed dates from immutable to mutable in generate_home_response
- Added a reversal step (dates.reverse();) to alter the order of dates

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant get_alerts_info
    participant AlertHandler
    Caller->>get_alerts_info: Call get_alerts_info()
    get_alerts_info->>AlertHandler: Iterate over alerts
    loop For each alert
        AlertHandler->>get_alerts_info: Return alert severity
        alt Severity is Critical
            get_alerts_info->>get_alerts_info: Increment critical counter
        else Other severities
            get_alerts_info->>get_alerts_info: Process normally
        end
    end
    get_alerts_info->>Caller: Return AlertsInfo with all counts
Loading
sequenceDiagram
    participant Caller
    participant generate_home_response
    participant DatesGenerator
    Caller->>generate_home_response: Request home response
    generate_home_response->>DatesGenerator: Generate date list (0 to 6)
    DatesGenerator->>generate_home_response: Return list of date strings
    generate_home_response->>generate_home_response: Reverse date list order
    generate_home_response->>Caller: Return modified home response
Loading

Suggested reviewers

  • parmesant

Poem

Oh, what a twist in the code today,
I hopped through fields both new and gray.
Critical alerts I now do count,
And dates reversed before they mount.
A happy spin, in bytes and hops,
Celebrating change with joyful pops!
🐇✨

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ddd8c89 and 7a2e6d5.

📒 Files selected for processing (2)
  • src/alerts/mod.rs (4 hunks)
  • src/prism/home/mod.rs (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: coverage
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
🔇 Additional comments (6)
src/alerts/mod.rs (4)

889-889: Added critical severity tracking to AlertsInfo struct

The addition of the critical field to AlertsInfo struct aligns with the PR objective of enhancing the alerts information to include critical severity counts.


902-902: Initialized critical counter

Correctly initializing the counter for tracking critical severity alerts.


916-916: Added critical severity case handling

The implementation properly increments the critical counter when an alert with Critical severity is found, following the same pattern as other severity levels.


928-928: Included critical count in response

The critical count is correctly included in the returned AlertsInfo struct, completing the feature implementation.

src/prism/home/mod.rs (2)

152-152: Changed dates to mutable variable

Changed let dates to let mut dates to allow for modifying the dates collection after creation.


161-161: Added date sorting functionality

The addition of dates.reverse() implements the PR objective of presenting date-level statistics in sorted order. This reverses the dates from newest-to-oldest to oldest-to-newest, providing a chronological view in the response.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nitisht nitisht merged commit e7699c8 into parseablehq:main Mar 18, 2025
14 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Apr 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants