Skip to content

chore: update arrow to v54 and datafusion to v45 #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Mar 3, 2025

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Summary by CodeRabbit

  • Chores
    • Upgraded multiple underlying dependencies for enhanced system stability and performance.
  • New Features
    • Improved query processing by integrating advanced filtering capabilities.
    • Refined how column statistics are reported, improving data insights.
    • Introduced a new Constraints type to enhance physical plan creation.
    • Updated documentation for the Minute struct to reflect changes in module structure.

Copy link
Contributor

coderabbitai bot commented Mar 3, 2025

Walkthrough

This pull request updates dependency versions in the Cargo.toml file—bumping several Arrow-related libraries and DataFusion—while also integrating a new Constraints type into the query planning process. In the src/query/stream_schema_provider.rs file, a constraints field is added to the FileScanConfig in the physical plan creation method, and column statistics are modified by setting sum_value to Precision::Absent. Additionally, documentation comments are updated in src/utils/time.rs to reflect changes in import paths.

Changes

File(s) Summary
Cargo.toml Updated dependency versions: arrow, arrow-array, arrow-flight (with tls), arrow-ipc (with zstd), arrow-json, arrow-schema (with serde), arrow-select, parquet; bumped datafusion; updated arrow in dev-dependencies.
src/query/stream_schema_provider.rs Introduced new type Constraints; added constraints: Constraints::empty() to FileScanConfig in create_parquet_physical_plan; updated column statistics (sum_value: Precision::Absent) in partitioned_files.
src/utils/time.rs Updated documentation example import path for Minute struct from crate::utils::time::Minute to parseable::utils::time::Minute.

Sequence Diagram(s)

sequenceDiagram
    participant QP as Query Planner
    participant STP as StandardTableProvider
    participant FSC as FileScanConfig
    participant Stats as Statistics Module

    QP->>STP: create_parquet_physical_plan()
    STP->>FSC: initialize FileScanConfig (constraints = empty)
    FSC-->>STP: return config
    STP->>Stats: calculate column statistics (set sum_value = Absent)
    Stats-->>STP: return stats
    STP-->>QP: return physical plan
Loading

Poem

I'm a little rabbit, hopping along,
Upgrading our code and singing my song,
Dependencies leap from one version to next,
With constraints and stats now properly indexed,
I nibble on changes, joyful and bright—
Hoppy coding days to all, and to all a good night! 🐇

Suggested labels

for next release

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41c6fe1 and e3037e5.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • Cargo.toml (2 hunks)
  • src/query/stream_schema_provider.rs (3 hunks)
  • src/utils/time.rs (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/utils/time.rs
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/query/stream_schema_provider.rs
  • Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: coverage

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@de-sh de-sh marked this pull request as ready for review March 3, 2025 11:07
coderabbitai[bot]
coderabbitai bot previously approved these changes Mar 3, 2025
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge

@nitisht nitisht merged commit e361ca0 into parseablehq:main Mar 16, 2025
13 of 15 checks passed
@de-sh de-sh deleted the arrow-update branch March 16, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants