add tile api corrected

Author: nikhilsinhaparseable

src/handlers/http/modal/server.rs

@@ -280,30 +280,33 @@ impl Server {
                     ),
             )
             .service(
-                web::resource("/{dashboard_id}")
-                    .route(
-                        web::get()
-                            .to(dashboards::get_dashboard)
-                            .authorize(Action::GetDashboard),
-                    )
-                    .route(
-                        web::delete()
-                            .to(dashboards::delete_dashboard)
-                            .authorize(Action::DeleteDashboard),
+                web::scope("/{dashboard_id}")
+                    .service(
+                        web::resource("")
+                            .route(
+                                web::get()
+                                    .to(dashboards::get_dashboard)
+                                    .authorize(Action::GetDashboard),
+                            )
+                            .route(
+                                web::delete()
+                                    .to(dashboards::delete_dashboard)
+                                    .authorize(Action::DeleteDashboard),
+                            )
+                            .route(
+                                web::put()
+                                    .to(dashboards::update_dashboard)
+                                    .authorize(Action::CreateDashboard),
+                            ),
                     )
-                    .route(
-                        web::put()
-                            .to(dashboards::update_dashboard)
-                            .authorize(Action::CreateDashboard),
+                    .service(
+                        web::resource("/add_tile").route(
+                            web::put()
+                                .to(dashboards::add_tile)
+                                .authorize(Action::CreateDashboard),
+                        ),
                     ),
             )
-            .service(
-                web::resource("/add_tile").route(
-                    web::put()
-                        .to(dashboards::add_tile)
-                        .authorize(Action::CreateDashboard),
-                ),
-            )
     }
 
     // get the filters web scope

src/users/dashboards.rs

@@ -294,9 +294,10 @@ impl Dashboards {
         &self,
         dashboard_id: Ulid,
         user_id: &str,
-    ) -> Result<Dashboard, DashboardError> {
+    ) -> Result<(), DashboardError> {
         self.get_dashboard_by_user(dashboard_id, user_id)
             .await
-            .ok_or(DashboardError::Unauthorized)
+            .ok_or_else(|| DashboardError::Unauthorized)
+            .map(|_| ())
     }
 }