Skip to content

Commit 00a3b1e

Browse files
author
Devdutt Shenoi
committed
test: improve coverage
1 parent e592421 commit 00a3b1e

File tree

1 file changed

+14
-1
lines changed

1 file changed

+14
-1
lines changed

src/handlers/http/modal/mod.rs

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,8 @@ impl IngestorMetadata {
242242

243243
// get the ingestor metadata from staging
244244
let bytes = std::fs::read(path).expect("File should be present");
245-
let mut meta = Self::from_bytes(&bytes, options.flight_port).expect("Extracted ingestor metadata");
245+
let mut meta =
246+
Self::from_bytes(&bytes, options.flight_port).expect("Extracted ingestor metadata");
246247

247248
// compare url endpoint and port, update
248249
if meta.domain_name != url {
@@ -377,6 +378,18 @@ mod test {
377378
assert_eq!(rhs, lhs);
378379
}
379380

381+
#[test]
382+
fn from_bytes_with_port() {
383+
let meta = IngestorMetadata::from_bytes(br#"{"version": "", "port": "", "domain_name": "", "bucket_name": "", "token": "", "ingestor_id": "", "flight_port": ""}"#, 10).expect("Deserializable");
384+
assert_eq!(meta.flight_port, "");
385+
}
386+
387+
#[test]
388+
fn from_bytes_without_port() {
389+
let meta = IngestorMetadata::from_bytes(br#"{"version": "", "port": "", "domain_name": "", "bucket_name": "", "token": "", "ingestor_id": ""}"#, 10).expect("Deserializable");
390+
assert_eq!(meta.flight_port, "10");
391+
}
392+
380393
#[rstest]
381394
fn test_serialize_resource() {
382395
let im = IngestorMetadata::new(

0 commit comments

Comments
 (0)