Skip to content

ci: Fix flaky tests invalid server state: initialized #9178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 7, 2024

Pull Request

Issue

Attempt to fix flaky tests when the server isn't properly initialized. I believe this is caused by tests that shuts down the server to reproduce a disconnection and restarts. I am unable to reproduce this issue local so the CI should be ran a few times to ensure it works.

Closes: #9149

Approach

  • Properly handle server shutdown
  • Refactor helper.js
  • Add retry strategy if server isn't properly initialized
  • Properly handle open connections

Copy link

Thanks for opening this pull request!

@dplewis dplewis marked this pull request as draft July 7, 2024 02:37
@dplewis dplewis closed this Jul 7, 2024
@dplewis dplewis deleted the initialize-server branch July 7, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Tests Invalid server state: initialized
1 participant