Skip to content

fix: Security upgrade jsonwebtoken to 9.0.0 #8431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 15, 2023

Pull Request

Issue

The latest JWT library prevents mocking of the decode property, which we use to determine a JWT's headers.

Closes: #8427

Approach

Add ability to mock decode

Tasks

  • Add tests

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 15, 2023

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 94.13% // Head: 94.12% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (42d948d) compared to base (e016d81).
Patch coverage: 92.85% of modified lines in pull request are covered.

❗ Current head 42d948d differs from pull request most recent head f8e5cd7. Consider uploading reports for the commit f8e5cd7 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           release-5.x.x    #8431      +/-   ##
=================================================
- Coverage          94.13%   94.12%   -0.02%     
=================================================
  Files                182      183       +1     
  Lines              13779    13776       -3     
=================================================
- Hits               12971    12966       -5     
- Misses               808      810       +2     
Impacted Files Coverage Δ
src/Adapters/Auth/utils.js 87.50% <87.50%> (ø)
src/Adapters/Auth/apple.js 100.00% <100.00%> (ø)
src/Adapters/Auth/facebook.js 90.00% <100.00%> (-0.63%) ⬇️
src/Adapters/Auth/google.js 92.64% <100.00%> (-0.32%) ⬇️
src/batch.js 92.98% <0.00%> (-1.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy dblythy requested a review from a team February 16, 2023 04:16
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title fix: Security upgrade jsonwebtoken to 9.0.9 LTS fix: Security upgrade jsonwebtoken to 9.0.0 Feb 16, 2023
@mtrezza mtrezza merged commit 2c19c2e into parse-community:release-5.x.x Feb 16, 2023
parseplatformorg pushed a commit that referenced this pull request Feb 16, 2023
## [5.4.2](5.4.1...5.4.2) (2023-02-16)

### Bug Fixes

* Security upgrade jsonwebtoken to 9.0.0 ([#8431](#8431)) ([2c19c2e](2c19c2e))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.4.2

@parseplatformorg parseplatformorg added the state:released-5.x.x Released as LTS version label Feb 16, 2023
@dblythy dblythy deleted the fix-jwt branch February 16, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released-5.x.x Released as LTS version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants