Skip to content

feat: add Parse Server config to standard request object #8069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Moumouls
Copy link
Member

New Pull Request Checklist

Issue Description

Related issue: #7869

Approach

Forward the Parse Server Config through the standard request object available in all Parse Cloud functions/triggers.

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@Moumouls Moumouls requested a review from a team June 24, 2022 10:49
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #8069 (56d6516) into alpha (42c9543) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            alpha    #8069      +/-   ##
==========================================
- Coverage   94.14%   94.14%   -0.01%     
==========================================
  Files         182      182              
  Lines       13691    13692       +1     
==========================================
  Hits        12890    12890              
- Misses        801      802       +1     
Impacted Files Coverage Δ
src/Routers/FunctionsRouter.js 94.11% <ø> (ø)
src/cloud-code/Parse.Cloud.js 99.20% <ø> (ø)
src/triggers.js 95.34% <ø> (ø)
src/Controllers/HooksController.js 94.73% <100.00%> (+0.04%) ⬆️
src/batch.js 92.98% <0.00%> (-1.76%) ⬇️
src/RestWrite.js 94.42% <0.00%> (-0.16%) ⬇️
src/ParseServerRESTController.js 98.48% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42c9543...56d6516. Read the comment docs.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moumouls
Copy link
Member Author

lets close this one since @dblythy implemented the singleton strategy

@Moumouls Moumouls closed this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants