-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Features Endpoint for Dashboard. #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sweet! I think @nlutsenko made a middleware for enforcing master key on an endpoint, but otherwise LGTM. |
Yup, lgtm otherwise, encourage to use the middleware if you need to enforce the master key. |
@nlutsenko can you confirm you're referring to the middleware being used in |
36407fc
to
66eaf6c
Compare
@peterdotjs updated the pull request. |
@peterdotjs Yes, there was functionality added by @flovilmart that allowed plugging middleware into PromiseRouter. |
I think we can probably skip the single element array. Also, I remembered the that endpoint for getting a single schema doesn't use |
@peterdotjs the problem with the middleware thing is that it doesn't exit early... for some obscure reason returning a Promise.reject() keeps it going |
Oh yeah, were you going to include the server version in this endpoint? I wanted to display it in the apps index. Also it would be pretty sweet to have the server "version" be a git hash or something if you are hacking on the server. Fake edit: The output of |
Sorry for all the scope creep :( feel free to ignore |
Note: Logs endpoint is different from the Parse.com logs endpoint, so it should be marked as not supported until we can get feature parity (enough for the dashboard to work, at least |
@drew-gross could we get a spec for the logs endpoint? |
Easiest way is probably to go to dashboard.parse.com and view the two logs pages and capture the request. |
Config endpoint also doesn't match close enough to use on the dashboard. |
I can work on that |
Merging this myself so I can do some work on top of it. |
Features Endpoint for Dashboard.
Features endpoint based on discussion #611