Skip to content

Features Endpoint for Dashboard. #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Conversation

peterdotjs
Copy link
Contributor

Features endpoint based on discussion #611

@drew-gross
Copy link
Contributor

Sweet! I think @nlutsenko made a middleware for enforcing master key on an endpoint, but otherwise LGTM.

@nlutsenko
Copy link
Contributor

Yup, lgtm otherwise, encourage to use the middleware if you need to enforce the master key.

@peterdotjs
Copy link
Contributor Author

@nlutsenko can you confirm you're referring to the middleware being used in FilesRouter? I'm not seeing it used in any of the PromiseRouter files.

@peterdotjs peterdotjs force-pushed the peterjs.featuresEndpoint branch from 36407fc to 66eaf6c Compare March 1, 2016 20:22
@facebook-github-bot
Copy link

@peterdotjs updated the pull request.

@nlutsenko
Copy link
Contributor

@peterdotjs Yes, there was functionality added by @flovilmart that allowed plugging middleware into PromiseRouter.

@drew-gross
Copy link
Contributor

I think we can probably skip the single element array. Also, I remembered the that endpoint for getting a single schema doesn't use results :( so maybe it's not critical

@flovilmart
Copy link
Contributor

@peterdotjs the problem with the middleware thing is that it doesn't exit early... for some obscure reason returning a Promise.reject() keeps it going

@drew-gross
Copy link
Contributor

Oh yeah, were you going to include the server version in this endpoint? I wanted to display it in the apps index. Also it would be pretty sweet to have the server "version" be a git hash or something if you are hacking on the server.

Fake edit: The output of git describe --dirty sounds ideal for the "version" while you are developing.

@drew-gross
Copy link
Contributor

Sorry for all the scope creep :( feel free to ignore

@drew-gross
Copy link
Contributor

Note: Logs endpoint is different from the Parse.com logs endpoint, so it should be marked as not supported until we can get feature parity (enough for the dashboard to work, at least

@flovilmart
Copy link
Contributor

@drew-gross could we get a spec for the logs endpoint?

@drew-gross
Copy link
Contributor

Easiest way is probably to go to dashboard.parse.com and view the two logs pages and capture the request.

@drew-gross
Copy link
Contributor

Config endpoint also doesn't match close enough to use on the dashboard.

@flovilmart
Copy link
Contributor

I can work on that

@drew-gross
Copy link
Contributor

Merging this myself so I can do some work on top of it.

drew-gross added a commit that referenced this pull request Mar 1, 2016
@drew-gross drew-gross merged commit 72e6eae into master Mar 1, 2016
@peterdotjs peterdotjs deleted the peterjs.featuresEndpoint branch March 9, 2016 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants