-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
PG: Add dates to group aggregate #4549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4549 +/- ##
==========================================
+ Coverage 92.88% 92.91% +0.02%
==========================================
Files 118 118
Lines 8457 8491 +34
==========================================
+ Hits 7855 7889 +34
Misses 602 602
Continue to review full report at Codecov.
|
@flovilmart I just realized that Postgres doesn't store dates as UTC like mongo. Is that proper functionality? |
ALL dates should be UTC (that’s the expected behavior). If it isn’t, then... that’s quite problematic :/ |
For instance the objects I just created on postgres look like |
ouch yeah all dates should be UTC, but becaut they have the TZ info, not all is lost :) |
@flovilmart should we convert them to UTC or leave them be? |
@flovilmart The PG date storage aside how does this look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
@flovilmart Thanks. What about the node vulnerability? |
* PG: Add dates to group aggregate * returns dates as UTC
Closes #4546
Let me know if more tests are needed.
I didn't really know how to write a test case for createdAt / updatedAt.
Also, I don't think
it_only_db('mongo')
works anymore.