Scrub Passwords with URL Encoded Characters #4433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4433 +/- ##
=========================================
+ Coverage 92.69% 92.79% +0.1%
=========================================
Files 118 118
Lines 8353 8358 +5
=========================================
+ Hits 7743 7756 +13
+ Misses 610 602 -8
Continue to review full report at Codecov.
|
montymxb
added
the
type:bug
flovilmart
previously approved these changes
Dec 19, 2017
|
Looks good, I'm wondering if we should not do something about the logging, perhaps use only the path part of the URL, and rebuild the query string based on the decoded query string? |
|
The matching is a bit iffy as is honestly. Reconstructing via the params and if one is password redacting the value without having to pattern match would be equally effective, if not also less error prone. |
|
Yep that's what I'm thinking as well. |
flovilmart
approved these changes
Dec 29, 2017
flovilmart
pushed a commit
that referenced
this pull request
Dec 29, 2017
* scrub passwords with url encoded characters from logs * compose query string from parsed params, redacting based on key if needed
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
* scrub passwords with url encoded characters from logs * compose query string from parsed params, redacting based on key if needed
mtrezza
removed
the
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that since login is performed over GET passwords can be urlencoded when trying to screen them from the logs. This can problematic as we check against a decoded version of the same password, which will not match a password with url encoded characters in the url/query.
This fixes it by running
encodeURIComponenton our decoded password value, and uses that encoded value to screen against the password in the url/query. Additionally this adds some tests to LogsRouter.spec.js for enforcing that passwords (encoded or not) are properly screened in logs from here on out.