Adds ability to login with email when provided as username #4420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4420 +/- ##
==========================================
- Coverage 92.7% 92.66% -0.05%
==========================================
Files 118 118
Lines 8346 8353 +7
==========================================
+ Hits 7737 7740 +3
- Misses 609 613 +4
Continue to review full report at Codecov.
|
|
I'm trying to think of any issues this could cause, but it seems pretty
good honestly. Emails as a login id are pretty good as they rarely change
and are easy to remember (usually). Having a username would become
extraneous at first glance, but having it allows users to ne identified
without giving away their email. Can't login atm but I approve
… On Dec 11, 2017 10:48 AM, "Arthur Cinader" ***@***.***> wrote:
***@***.**** approved this pull request.
reasonable approach.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4420 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE1d4D9eayXIW56gSDkwij7-ZOi9R1Mhks5s_XjygaJpZM4Q8vdM>
.
|
|
Alright. As long as we’re onboard for the corner case, le’ts go with it! |
flovilmart
added a commit
that referenced
this pull request
Dec 29, 2017
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should solve some issue with the clients trying to login with the email as the username.
Some additional checks could be made (like is the username 'email-like') but I'm not sure it would not cause more issues than right now.
For the sake of backwards compatibility, and to solve an unlikely edge case when User1 has email and User2 has the username == user1.email, the server will always prefer the user with the username matching (not the email). Perhaps that's not the right strategy. Let me know what you guys think.