[NEW] Allows dot-notation to match against a complex structure when using matchesKeyInQuery #4399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4399 +/- ##
==========================================
- Coverage 92.7% 92.66% -0.04%
==========================================
Files 118 118
Lines 8346 8346
==========================================
- Hits 7737 7734 -3
- Misses 609 612 +3
Continue to review full report at Codecov.
|
flovilmart
previously approved these changes
Nov 29, 2017
montymxb
suggested changes
Nov 29, 2017
spec/ParseQuery.spec.js
Outdated
| }) | ||
| }); | ||
|
|
||
| it('should match complex structure with dot notation when using matchesKeyInQuery', function(done) { |
There was a problem hiding this comment.
Should probably change the description to use doesNotMatchKeyInQuery
There was a problem hiding this comment.
DOH, @montymxb thanks for catching.
|
Just a note tests are good here 👍, failure is the unrelated moment.js regex vuln. |
montymxb
approved these changes
Nov 29, 2017
|
Thanks @acinader and others! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just finishes out #4308 which @bohemima did the heavy lifting on. Fixes #4346.
It's too useful to let fester ;)