Add Parse Server Generic Email Adapter to README #4101
Conversation
Added a generic email plugin to send Parse Server password reset and verification emails with generic accounts like Gmail. This module uses the nodemailer library.
Codecov Report
@@ Coverage Diff @@
## master #4101 +/- ##
==========================================
- Coverage 92.69% 92.67% -0.03%
==========================================
Files 118 118
Lines 8353 8353
==========================================
- Hits 7743 7741 -2
- Misses 610 612 +2
Continue to review full report at Codecov.
|
|
What's the status on this PR? |
README.md
Outdated
| @@ -310,7 +310,7 @@ You can also use other email adapters contributed by the community such as: | |||
| - [parse-server-mailgun-adapter-template](https://www.npmjs.com/package/parse-server-mailgun-adapter-template) | |||
| - [parse-server-mailjet-adapter](https://www.npmjs.com/package/parse-server-mailjet-adapter) | |||
| - [simple-parse-smtp-adapter](https://www.npmjs.com/package/simple-parse-smtp-adapter) | |||
|
|
|||
| - [parse-server-genericemail-adapter](https://www.npmjs.com/package/parse-server-genericemail-adapter) | |||
There was a problem hiding this comment.
you need an empty line after that please.
There was a problem hiding this comment.
yes, have added the empty line
Have added the empty line
|
Have made the changes |
montymxb
changed the title
|
@premithk The adapter sounds nice, but to be honest I don't feel this project is at a point where we should endorse it on our page. It indicates it was last tested against parse-server 2.2.13 and the README could use some work. If you wrote this you can check out the other adapters to see a good example of some solid READMEs. Yours doesn't have to copy or anything, but it should be something professional that we would be happy to have as a link to on our page. Additionally, and maybe this can't be changed, but the name is missing a hyphen where I would expect parse-server-generic-email-adapter. Not trying to bash on the adapter though, what it does seems quite useful. |
|
@montymxb thank you, i see your point, let me test it against the latest parse-server and update the readme. Regarding the missing hyphen i don't know if i can change that :( |
|
@montymxb have updated the readme, can you please check and see if that is enough. (At your leisure). Thank you |
|
@premithk thanks for the changes, there were some additional things I noticed on the repo still. I'll open up a PR there when I get a chance. |
|
Sure, thank you! :) |
|
@premithk I'm going to take a look at your repo to suggest some changes. On another note regarding the package name, if you're willing to we would like to have the name cleaned up as mentioned above. You could publish a new npm package and deprecate the old one. This has been done before and there's a deprecation guide for npm modules as well as a little discussion on it in this SO post. It's asking a bit, but it would be nice 😄 . |
|
@montymxb thank you for the pull request, i've merged those. lemme try and clean up the npm name issue |
|
@montymxb i have deprecated the old funky name one and published a new npm package with the above mentioned name https://www.npmjs.com/package/parse-server-generic-email-adapter. Also have updated the readme with the package name changes. Please check at your leisure. |
Renamed to new npm module
There was a problem hiding this comment.
Alright the package looks much better now. One more thing though, you need to update all instances of parse-server-genericemail-adapter in your readme to the new package name as well. Once that's done, ,and it's been republishd on npm so the README is corrected, let me know.
|
@montymxb have updated the readme with the new package names and republished on npm. Thank you. |
|
Awesome! I'm out and about but I'll be back on this later today. I'm going
to give things another good look and test drive the adapter, but I think
this is just about good.
…On Dec 10, 2017 6:02 PM, "Premith" ***@***.***> wrote:
@montymxb <https://github.com/montymxb> have updated the readme with the
new package names and republished on npm. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE1d4Cej8l5R4vTAKz-AA_YewKEIUWiqks5s_I0lgaJpZM4O7a_C>
.
|
There was a problem hiding this comment.
Alright I would say this is approved 
.
Tested this against a little fake gmail account I had, and it works! Was pleasantly surprised to see it send with very little work.
The one thing I did note was a deprecation notice regarding the version of nodemailer you're using.
WARN deprecated [email protected]: All versions below 4.0.1 of Nodemailer are deprecated. See https://nodemailer.com/status/
Since it's just a deprecation this is acceptable for the moment, but I would address it by bumping up the version when you have time.
As a final note, although I'm giving this approval, I would like to get one more word from @flovilmart to see if he has any last thoughts or concerns.
|
@montymxb have merged your changes. thank you |
|
@premithk just rerunning CI to so we can bring this in. Since the requested changes have been made we're definitely good to go. |
|
Thanks again @premithk ! |
|
Thanks a lot @montymxb |
Added a generic email plugin to send Parse Server password reset and verification emails with generic accounts like Gmail. This module uses the nodemailer library.
Added a generic email plugin to send Parse Server password reset and verification emails with generic accounts like Gmail. This module uses the nodemailer library.
Added a generic email plugin to send Parse Server password reset and verification emails with generic accounts like Gmail. This module uses the nodemailer library.