Skip to content

Update PostgresStorageAdapter.js #3869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2017
Merged

Update PostgresStorageAdapter.js #3869

merged 3 commits into from
May 28, 2017

Conversation

vitaly-t
Copy link
Contributor

refactoring deleteClass.

@codecov
Copy link

codecov bot commented May 27, 2017

Codecov Report

Merging #3869 into master will increase coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3869      +/-   ##
==========================================
+ Coverage   89.62%   90.19%   +0.56%     
==========================================
  Files         114      114              
  Lines        7550     7549       -1     
==========================================
+ Hits         6767     6809      +42     
+ Misses        783      740      -43
Impacted Files Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.45% <100%> (-0.01%) ⬇️
src/Push/PushWorker.js 94.54% <0%> (+1.81%) ⬆️
src/Adapters/Cache/InMemoryCache.js 100% <0%> (+7.69%) ⬆️
src/Adapters/Cache/RedisCacheAdapter.js 91.48% <0%> (+85.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aedaae1...b333818. Read the comment docs.

@vitaly-t
Copy link
Contributor Author

vitaly-t commented May 27, 2017

The failure seems to be due to an unreliable test, not change-related.

@flovilmart
Copy link
Contributor

Yeah, we got that test that keep failing for no good reasons.

@flovilmart flovilmart merged commit d149d16 into parse-community:master May 28, 2017
@flovilmart
Copy link
Contributor

@vitaly-t thanks for the improvement!

@vitaly-t vitaly-t deleted the patch-1 branch May 28, 2017 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants