fix adapter string config #3538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test that exemplify that behavior? |
flovilmart
suggested changes
Feb 20, 2017
src/Adapters/AdapterLoader.js
Outdated
| @@ -23,6 +23,9 @@ export function loadAdapter(adapter, defaultAdapter, options) { | |||
| if (adapter.default) { | |||
| adapter = adapter.default; | |||
| } | |||
| if(options.adapter) { | |||
There was a problem hiding this comment.
yeah - its a pain to test locally (windows) - so for tiny changes its easiest to just PR them and let travis let me know if its ok.
just trying a variation, and if its ok I'll add a test.
atm you cant configure a push adapter via string, which is a pain.
jeacott1
force-pushed
the
fix-adapter-string-loader
branch
from
88e5649 to
0e11a7f
Compare
|
@jeacott1 updated the pull request - view changes |
jeacott1
force-pushed
the
fix-adapter-string-loader
branch
from
0e11a7f to
52b07f6
Compare
|
@jeacott1 updated the pull request - view changes |
|
There is the test:win command that is specifically designed for windows. |
|
Also, if you're using the CLi, you'll note that the parser is an objectParser not a moduleParser (unlike emailAdapter options). I suggest you open an issue first, with the proper error you encounter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows push adapter to be properly configured via string config