Skip to content

Update bcryptjs to version 2.4.3 🚀 #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

bcryptjs just published its new version 2.4.3.

State Update 🚀
Dependency bcryptjs
New version 2.4.3
Type dependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of bcryptjs.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


The new version differs by 14 commits .

  • f7dd725 2.4.3
  • 2d20276 Actually build .min.js.gz
  • 9323764 Updated benchmark data and performance difference value
  • 2fa2b7c Switched CC to use simple optimizations, also fixes #55
  • 048c58a Cleanup
  • 5be2eb6 Post-merge; Fixed genSalt not defaulting to default rounds with omitted callback (promise), see #58
  • bfba82c Merge pull request #53 from cruxic/darn-fast
  • 0b7c11a Unroll the _encipher() loop. Saves ~80ms on my machine (at cost 12).
  • 9350b93 Small speedup by using >>> in the _encipher() loop which allows us to remove two & 0xFF instructions. This saves ~30ms on my machine (at cost 12).
  • 422f265 Huge speedup by using typed arrays (Int32Array) for P and S. I suspect this is because it packs the data tighter in RAM so it can fit in the CPU cache more easily.
  • 2ab0521 README: Corrected promises example, see #51
  • c473690 Updated travis to use g++-4.8
  • f0b5518 Merge pull request #48 from JakobLofgren/master
  • de55e41 Add Promise example in Async code examples

See the full diff.


✨ Try the all new Greenkeeper GitHub Integration
With Integrations first-class bot support landed on GitHub and we’ve rewritten Greenkeeper to take full advantage of it. Simpler setup, fewer pull-requests, faster than ever.

Screencast

Try it today. Free for private repositories during beta.

@acinader acinader merged commit e32a37c into master Feb 8, 2017
@drew-gross drew-gross deleted the greenkeeper-bcryptjs-2.4.3 branch February 8, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants