-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
adding TTL option for redis cache adapter #3397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b671dbe
adding TTL option for redis cache adapter
f0ster 95b5cb9
Merge branch 'master' into master
f0ster 75ae1a4
adding test for RedisCacheAdapter
f0ster 6a5c0dd
Fixing adapater var name
f0ster 947471b
changing timeout
f0ster 6479b06
updating default time
f0ster cd8300c
Fix the redis cache spec to construct the cache with the anticipated ttl
0129cac
Merge pull request #1 from acinader/fix-redis-cache-test
f0ster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
var RedisCacheAdapter = require('../src/Adapters/Cache/RedisCacheAdapter').default; | ||
|
||
describe('RedisCacheAdapter', function() { | ||
var KEY = 'hello'; | ||
var VALUE = 'world'; | ||
|
||
function wait(sleep) { | ||
return new Promise(function(resolve) { | ||
setTimeout(resolve, sleep); | ||
}) | ||
} | ||
|
||
it('should get/set/clear', (done) => { | ||
var cache = new RedisCacheAdapter({ | ||
ttl: NaN | ||
}); | ||
|
||
cache.put(KEY, VALUE) | ||
.then(() => cache.get(KEY)) | ||
.then((value) => expect(value).toEqual(VALUE)) | ||
.then(() => cache.clear()) | ||
.then(() => cache.get(KEY)) | ||
.then((value) => expect(value).toEqual(null)) | ||
.then(done); | ||
}); | ||
|
||
it('should expire after ttl', (done) => { | ||
var cache = new RedisCacheAdapter(null, 1); | ||
|
||
cache.put(KEY, VALUE) | ||
.then(() => cache.get(KEY)) | ||
.then((value) => expect(value).toEqual(VALUE)) | ||
.then(wait.bind(null, 2)) | ||
.then(() => cache.get(KEY)) | ||
.then((value) => expect(value).toEqual(null)) | ||
.then(done); | ||
}); | ||
|
||
it('should find un-expired records', (done) => { | ||
var cache = new RedisCacheAdapter(null, 5); | ||
|
||
cache.put(KEY, VALUE) | ||
.then(() => cache.get(KEY)) | ||
.then((value) => expect(value).toEqual(VALUE)) | ||
.then(wait.bind(null, 1)) | ||
.then(() => cache.get(KEY)) | ||
.then((value) => expect(value).not.toEqual(null)) | ||
.then(done); | ||
}); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what!@?! mind blown. I don't even understand how returning expect.... is "thenable", but super cool idiom. going to start using....