Obfuscate password name value pairs in log strings

[flovilmart]

fixes: #2680

[facebook-github-bot]

@flovilmart updated the pull request - view changes

[ghost]

@flovilmart updated the pull request - view changes

[acinader]

@flovilmart oh, now i see what you mean in #2680 (comment)

I think that what you're suggesting is trying something like:

export class LoggerController extends AdaptableController {

  log(level, args) {
    args = [].concat(level, [...args]);
+   args.forEach(e => this.cleanLogString(e))
    this.adapter.log.apply(this.adapter, args);
  }

and remove cleaning from the client's responsibility. I like it and will take a look, but can't get to tonight...will need to take a look at what comes into ...args :)

[flovilmart]

No problem, there's no rush :)

[skinp]

LGTM

[flovilmart]

Alright let's merge that so it's available on the latest branch, we'll refactor later