-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Mask sensitive information when logging #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 92.19%
@@ master #1790 diff @@
==========================================
Files 87 87
Lines 6206 6210 +4
Methods 1069 1069
Messages 0 0
Branches 1292 1293 +1
==========================================
+ Hits 5720 5725 +5
+ Misses 486 485 -1
Partials 0 0
|
@Marco129 updated the pull request. |
I think it might make more sense to do this at the object level, ie. check if the request is for the _User class, and set the password to |
@Marco129 updated the pull request. |
@Marco129 updated the pull request. |
@drew-gross Agree with that. Updated the PR to reflect the changes. |
I'm still getting passwords being shown in my log file here, running parse-server 2.2.12 `at=info`` method=GET path="/1/login?password=somepassword&username=someusername" host=someapp.herokuapp.com request_id=a8dae8fc-7c0a-4e2c-82de-493b168e2291 fwd="54.227.100.56" dyno=web.1 connect=0ms service=382ms status=200 bytes=1632 |
Related to issue #1704
Not sure whether the test case should put inside
FileLoggerAdapter.spec.js