Skip to content

Mask sensitive information when logging #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2016

Conversation

Marco129
Copy link
Contributor

Related to issue #1704
Not sure whether the test case should put inside FileLoggerAdapter.spec.js

@codecov-io
Copy link

codecov-io commented May 14, 2016

Current coverage is 92.19%

Merging #1790 into master will increase coverage by <.01%

  1. File src/ParseServer.js (not in diff) was modified. more
    • Misses -1
    • Partials 0
    • Hits +1
@@             master      #1790   diff @@
==========================================
  Files            87         87          
  Lines          6206       6210     +4   
  Methods        1069       1069          
  Messages          0          0          
  Branches       1292       1293     +1   
==========================================
+ Hits           5720       5725     +5   
+ Misses          486        485     -1   
  Partials          0          0          

Powered by Codecov. Last updated by 1854928...dbb04e6

@ghost
Copy link

ghost commented May 14, 2016

@Marco129 updated the pull request.

@drew-gross
Copy link
Contributor

I think it might make more sense to do this at the object level, ie. check if the request is for the _User class, and set the password to ******** if it is. Then we will only filter exactly what we want, instead of catching things like password: blah inside other columns or inside objects. That might require bigger changes to where we log stuff though. Thoughts?

@ghost
Copy link

ghost commented May 15, 2016

@Marco129 updated the pull request.

@Marco129 Marco129 changed the title Mask sensitive information when logging [WIP] Mask sensitive information when logging May 15, 2016
@ghost
Copy link

ghost commented May 15, 2016

@Marco129 updated the pull request.

@Marco129
Copy link
Contributor Author

@drew-gross Agree with that. Updated the PR to reflect the changes.

@Marco129 Marco129 changed the title [WIP] Mask sensitive information when logging Mask sensitive information when logging May 17, 2016
@drew-gross drew-gross merged commit 4096518 into parse-community:master May 17, 2016
@Marco129 Marco129 deleted the mask-sensitive branch May 19, 2016 10:20
@jameslin101
Copy link

jameslin101 commented Jun 19, 2016

I'm still getting passwords being shown in my log file here, running parse-server 2.2.12

`at=info`` method=GET path="/1/login?password=somepassword&username=someusername" host=someapp.herokuapp.com request_id=a8dae8fc-7c0a-4e2c-82de-493b168e2291 fwd="54.227.100.56" dyno=web.1 connect=0ms service=382ms status=200 bytes=1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants