Cleanup delete schema #1604
Merged
Cleanup delete schema #1604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.31%@@ master #1604 diff @@
========================================
Files 87 87
Lines 5543 6154 +611
Methods 0 1082 +1082
Branches 1055 1278 +223
========================================
+ Hits 5145 5681 +536
- Misses 385 473 +88
+ Partials 13 0 -13
|
| }); | ||
| } | ||
|
|
||
| _allCollections() { |
There was a problem hiding this comment.
can we make it a function with this passed as a prop like:
function allCollections(storageAdapter) { ... }
There was a problem hiding this comment.
Just so it's not exported? Sure.
drew-gross
force-pushed
the
cleanup-delete-schema
branch
from
329182c to
558c237
Compare
|
@drew-gross updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going to do more in this PR but there is a dependency on count so I'm going to break that dependency before going further with this.