Passing the application's LoggerAdapter to requests #1565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blacha updated the pull request. |
| done(); | ||
| }); | ||
| }); | ||
| }); |
Current coverage is
|
|
Just The small nit on The trailing line break and I believe it's good to go. |
|
@blacha updated the pull request. |
This allows access to logging inside cloud code and triggers via
request.log.info
request.log.error
|
@blacha updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows access to logging inside cloud code and triggers via
request.log.info
request.log.error
This is working around #1563 by grabbing only the latest log messages.