-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Don't send tags object to Parse file adapter when no tags are set #7129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for reporting. Can you please write a test case where the tags in |
I have classified this as a bug with severity 4:
|
@mtrezza I will prepare test and look on fix as well. |
This is also a blocker for Linode Object Storage. I was able to make it work by downgrading the |
Thanks for confirming, @alioguzhan. Would you want to make a PR to fix this? |
Sure @mtrezza . If you provide me a little guidance by pointing the starting point, I can make a PR. AFAIK, this is occurring because the parse-server sends |
That's correct. I suggest to read the original discussion that lead to the opening of this issue. The general approach would be to only set the tags property of a |
This should be fixed by #7300 |
New Issue Checklist
Issue Description
We are using Digital Ocean Spaces for storing files. It is S3 compatible storage, so that we are using
parse-server-s3-adapter
. However, DO Spaces don't support all S3 features - one of unsupported are tags. In current version ofparse-server-s3-adapter
every upload fails. The problem is, that ParseFile containstags
object even when no tags are set.Firstly, I proposed change in
parse-server-s3-adapter
adapter itself (see pull request parse-community/parse-server-s3-adapter#135), but after some discussion was raised question, if this should not be handled in ParseFile itself. I looked to code and by default ParseFile sets both metadata and tags to empty objects. In this case, s3 files adapter send those options to S3 as empty tags list.Is there any reason why both
tags
andmetadata
are always empty objects and not undefined when not set? Maybe this is architectural decision, but files adapters handles case, when tags and metadata are undefined and in that case, they correctly don't set them.Steps to reproduce
Actual Outcome
Current verson of Parse server don't work with Digital Ocean spaces
Expected Outcome
It should work with Digital Ocean Spaces
Server
4.5.0
docker nodejs
Digital Ocean
Database
Postgres
Client
CloudCode
The text was updated successfully, but these errors were encountered: