nits

Author: flovilmart

src/Controllers/DatabaseController.js

@@ -1007,10 +1007,10 @@ class DatabaseController {
       })
   }
 
-  addPointerPermissions(schema: any, className: string, operation: string, query: any, aclGroup: any[] = []) {
+  addPointerPermissions(schema: SchemaController.SchemaController, className: string, operation: string, query: any, aclGroup: any[] = []) {
   // Check if class has public permission for operation
   // If the BaseCLP pass, let go through
-    if (schema.testBaseCLP(className, aclGroup, operation)) {
+    if (schema.testPermissionsForClassName(className, aclGroup, operation)) {
       return query;
     }
     const perms = schema.perms[className];

src/Controllers/SchemaController.js

@@ -859,12 +859,12 @@ export default class SchemaController {
     return Promise.resolve(this);
   }
 
-  // Validates the base CLP for an operation
-  testBaseCLP(className: string, aclGroup: string[], operation: string) {
-    return SchemaController.testBaseCLP(this.perms[className], aclGroup, operation);
+  testPermissionsForClassName(className: string, aclGroup: string[], operation: string) {
+    return SchemaController.testPermissions(this.perms[className], aclGroup, operation);
   }
 
-  static testBaseCLP(classPermissions: ?any, aclGroup: string[], operation: string) {
+  // Tests that the class level permission let pass the operation for a given aclGroup
+  static testPermissions(classPermissions: ?any, aclGroup: string[], operation: string): boolean {
     if (!classPermissions || !classPermissions[operation]) {
       return true;
     }
@@ -881,7 +881,7 @@ export default class SchemaController {
 
   // Validates an operation passes class-level-permissions set in the schema
   static validatePermission(classPermissions: ?any, className: string, aclGroup: string[], operation: string) {
-    if (SchemaController.testBaseCLP(classPermissions, aclGroup, operation)) {
+    if (SchemaController.testPermissions(classPermissions, aclGroup, operation)) {
       return Promise.resolve();
     }
 

src/LiveQuery/ParseLiveQueryServer.js

@@ -47,12 +47,11 @@ class ParseLiveQueryServer {
     Parse.initialize(config.appId,  Parse.javaScriptKey, config.masterKey);
 
     // The cache controller is a proper cache controller
-    // With access to User and Roles
+    // with access to User and Roles
     this.cacheController = getCacheController(config)
 
-    // This auth cache stores the promises for each auth resolution
-    // The main benefit is to be able to reuse the same user / session token resolution
-    // And to chain
+    // This auth cache stores the promises for each auth resolution.
+    // The main benefit is to be able to reuse the same user / session token resolution.
     this.authCache = new LRU({
       max: 500, // 500 concurrent
       maxAge: 60 * 60 * 1000 // 1h
@@ -354,7 +353,7 @@ class ParseLiveQueryServer {
     const authPromise = getAuthForSessionToken({ cacheController: this.cacheController, sessionToken: sessionToken })
       .then((auth) => {
         return { auth, userId: auth && auth.user && auth.user.id };
-      }, () => {
+      }).catch(() => {
         // If you can't continue, let's just wrap it up and delete it.
         // Next time, one will try again
         this.authCache.del(sessionToken);