Skip to content

Commit a005874

Browse files
authored
refactor: Upgrade commander from 5.1.0 to 10.0.1 (#8557)
1 parent 4c1093e commit a005874

File tree

4 files changed

+26
-12
lines changed

4 files changed

+26
-12
lines changed

package-lock.json

+23-8
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"@parse/push-adapter": "4.1.2",
2929
"bcryptjs": "2.4.3",
3030
"body-parser": "1.20.1",
31-
"commander": "5.1.0",
31+
"commander": "10.0.1",
3232
"cors": "2.8.5",
3333
"deepcopy": "2.1.0",
3434
"express": "4.18.2",

spec/CLI.spec.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('commander additions', () => {
7474
done();
7575
});
7676

77-
it('should load properly use args over env', done => {
77+
it('should load properly use args over env', () => {
7878
commander.loadDefinitions(testDefinitions);
7979
commander.parse(['node', './CLI.spec.js', '--arg0', 'arg0Value', '--arg4', ''], {
8080
PROGRAM_ARG_0: 'arg0ENVValue',
@@ -86,7 +86,6 @@ describe('commander additions', () => {
8686
expect(commander.arg1).toEqual('arg1ENVValue');
8787
expect(commander.arg2).toEqual(4);
8888
expect(commander.arg4).toEqual('');
89-
done();
9089
});
9190

9291
it('should fail in action as port is invalid', done => {

src/cli/utils/commander.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -136,5 +136,5 @@ Command.prototype.getOptions = function () {
136136
}, {});
137137
};
138138

139-
export default new Command();
139+
export default new Command().storeOptionsAsProperties();
140140
/* eslint-enable no-console */

0 commit comments

Comments
 (0)